ci: add packaging test workflow

Author: taeold

scripts/test-packaging.sh

@@ -1,7 +1,7 @@
 #!/bin/bash
 set -e
 
-# Argument 1 (Optional): Path to a pre-built tarball.
+# Argument 1: Path to a pre-built tarball.
 # If not provided, the script will run 'npm run build' and 'npm pack' locally.
 PREBUILT_TARBALL="$1"
 
@@ -15,6 +15,7 @@ trap cleanup EXIT
 
 # Save current directory to resolve relative paths later
 START_DIR="$(pwd)"
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 
 if [ -n "$PREBUILT_TARBALL" ]; then
   echo "Using prebuilt tarball: $PREBUILT_TARBALL"
@@ -25,8 +26,6 @@ if [ -n "$PREBUILT_TARBALL" ]; then
   TARBALL_PATH="$PREBUILT_TARBALL"
 else
   echo "Building project..."
-  # Ensure we are in the project root for building
-  SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
   cd "$SCRIPT_DIR/.."
   npm run build
 
@@ -41,34 +40,10 @@ pushd "$WORK_DIR" > /dev/null
 npm init -y > /dev/null
 npm install "$TARBALL_PATH" > /dev/null
 
-echo "Generating verification scripts..."
-node -e '
-const fs = require("fs");
-// Read the package.json of the INSTALLED package to verify what was actually packed
-const pkg = require("./node_modules/firebase-functions/package.json");
-const exports = Object.keys(pkg.exports);
-
-// Filter out non-code entrypoints (e.g. package.json if it were exported)
-const entryPoints = exports.filter(e => !e.endsWith(".json"));
-
-let cjsContent = "console.log(\"Verifying CJS exports...\");\n";
-let esmContent = "console.log(\"Verifying ESM exports...\");\n";
-
-for (const exp of entryPoints) {
-  const importPath = exp === "." ? "firebase-functions" : `firebase-functions/${exp.replace("./", "")}`;
-  cjsContent += `try { require("${importPath}"); console.log("✅ CJS: ${importPath}"); } catch (e) { console.error("❌ CJS Failed: ${importPath}", e); process.exit(1); }\n`;
-  esmContent += `try { await import("${importPath}"); console.log("✅ ESM: ${importPath}"); } catch (e) { console.error("❌ ESM Failed: ${importPath}", e); process.exit(1); }\n`;
-}
-
-fs.writeFileSync("verify-cjs.cjs", cjsContent);
-fs.writeFileSync("verify-esm.mjs", esmContent);
-'
-
-echo "Running CJS verification..."
-node verify-cjs.cjs
-
-echo "Running ESM verification..."
-node verify-esm.mjs
+echo "Running verification script..."
+# Copy the verification script to the work directory to ensure it resolves
+# the locally installed 'firebase-functions' package.
+cp "$SCRIPT_DIR/verify-exports.mjs" .
+node verify-exports.mjs
 
 popd > /dev/null
-echo "✨ Packaging test passed!"

scripts/verify-exports.mjs

@@ -0,0 +1,57 @@
+import fs from 'fs';
+import path from 'path';
+import { createRequire } from 'module';
+
+const require = createRequire(import.meta.url);
+
+// Read the package.json of the INSTALLED package to verify what was actually packed
+const pkgPath = path.resolve(process.cwd(), 'node_modules/firebase-functions/package.json');
+if (!fs.existsSync(pkgPath)) {
+  console.error(`❌ Could not find installed package at ${pkgPath}`);
+  process.exit(1);
+}
+
+const pkg = JSON.parse(fs.readFileSync(pkgPath, 'utf8'));
+const exports = Object.keys(pkg.exports || {});
+
+// Filter out non-code entrypoints (e.g. package.json if it were exported)
+const entryPoints = exports.filter(e => !e.endsWith('.json'));
+
+console.log(`Found ${entryPoints.length} entry points to verify.`);
+
+let hasError = false;
+
+async function verify() {
+  console.log('\n--- Verifying CommonJS (require) ---');
+  for (const exp of entryPoints) {
+    const importPath = exp === '.' ? 'firebase-functions' : `firebase-functions/${exp.replace('./', '')}`;
+    try {
+      require(importPath);
+      console.log(`✅ CJS: ${importPath}`);
+    } catch (e) {
+      console.error(`❌ CJS Failed: ${importPath}`, e.message);
+      hasError = true;
+    }
+  }
+
+  console.log('\n--- Verifying ES Modules (import) ---');
+  for (const exp of entryPoints) {
+    const importPath = exp === '.' ? 'firebase-functions' : `firebase-functions/${exp.replace('./', '')}`;
+    try {
+      await import(importPath);
+      console.log(`✅ ESM: ${importPath}`);
+    } catch (e) {
+      console.error(`❌ ESM Failed: ${importPath}`, e.message);
+      hasError = true;
+    }
+  }
+
+  if (hasError) {
+    console.error('\n❌ Verification failed with errors.');
+    process.exit(1);
+  } else {
+    console.log('\n✨ All entry points verified successfully!');
+  }
+}
+
+verify();