Skip to content

Commit 9986040

Browse files
Apply suggestions from code review
Co-authored-by: pragatimodi <[email protected]>
1 parent 8fb5f2a commit 9986040

File tree

2 files changed

+25
-7
lines changed

2 files changed

+25
-7
lines changed

src/auth/project-config.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ export interface UpdateProjectConfigRequest {
5050

5151
/**
5252
* Response received when getting or updating the project config.
53-
* Currently only includes the reCAPTCHA and SMS Region config.
5453
*/
5554
export interface ProjectConfigServerResponse {
5655
smsRegionConfig?: SmsRegionConfig;
@@ -60,7 +59,6 @@ export interface ProjectConfigServerResponse {
6059

6160
/**
6261
* Request to update the project config.
63-
* Currently only includes the reCAPTCHA and SMS Region config.
6462
*/
6563
export interface ProjectConfigClientRequest {
6664
smsRegionConfig?: SmsRegionConfig;
@@ -145,7 +143,7 @@ export class ProjectConfig {
145143
* Build the corresponding server request for a UpdateProjectConfigRequest object.
146144
* @param configOptions - The properties to convert to a server request.
147145
* @returns The equivalent server request.
148-
*
146+
*
149147
* @internal
150148
*/
151149
public static buildServerRequest(configOptions: UpdateProjectConfigRequest): ProjectConfigClientRequest {

test/integration/auth.spec.ts

Lines changed: 24 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1227,7 +1227,12 @@ describe('admin.auth', () => {
12271227
multiFactorConfig: mfaConfig,
12281228
recaptchaConfig: {
12291229
emailPasswordEnforcementState: 'AUDIT',
1230-
managedRules: [{ endScore: 0.1, action: 'BLOCK' }],
1230+
managedRules: [
1231+
{
1232+
endScore: 0.1,
1233+
action: 'BLOCK',
1234+
},
1235+
],
12311236
useAccountDefender: true,
12321237
},
12331238
};
@@ -1263,7 +1268,12 @@ describe('admin.auth', () => {
12631268
multiFactorConfig: mfaConfig,
12641269
recaptchaConfig: {
12651270
emailPasswordEnforcementState: 'AUDIT',
1266-
managedRules: [{ endScore: 0.1, action: 'BLOCK' }],
1271+
managedRules: [
1272+
{
1273+
endScore: 0.1,
1274+
action: 'BLOCK',
1275+
},
1276+
],
12671277
useAccountDefender: true,
12681278
},
12691279
};
@@ -1276,7 +1286,12 @@ describe('admin.auth', () => {
12761286
multiFactorConfig: mfaConfig,
12771287
recaptchaConfig: {
12781288
emailPasswordEnforcementState: 'OFF',
1279-
managedRules: [{ endScore: 0.1, action: 'BLOCK' }],
1289+
managedRules: [
1290+
{
1291+
endScore: 0.1,
1292+
action: 'BLOCK',
1293+
},
1294+
],
12801295
},
12811296
};
12821297
const expectedProjectConfigSmsEnabledTotpDisabled: any = {
@@ -1293,7 +1308,12 @@ describe('admin.auth', () => {
12931308
},
12941309
recaptchaConfig: {
12951310
emailPasswordEnforcementState: 'OFF',
1296-
managedRules: [{ endScore: 0.1, action: 'BLOCK' }],
1311+
managedRules: [
1312+
{
1313+
endScore: 0.1,
1314+
action: 'BLOCK',
1315+
},
1316+
],
12971317
},
12981318
};
12991319

0 commit comments

Comments
 (0)