Skip to content

Commit e6d19a8

Browse files
committed
Add tests for PhoneNumber integration check
1 parent 56b43f3 commit e6d19a8

File tree

2 files changed

+32
-7
lines changed

2 files changed

+32
-7
lines changed

auth/user_mgt_test.go

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -795,15 +795,24 @@ var createUserCases = []struct {
795795
PhoneMultiFactorInfo: &PhoneMultiFactorInfo{
796796
PhoneNumber: "+11234567890",
797797
},
798-
DisplayName: "Spouse's phone number",
798+
DisplayName: "Phone Number active",
799+
FactorID: "phone",
800+
},
801+
{
802+
PhoneNumber: "+11234567890",
803+
DisplayName: "Phone Number deprecated",
799804
FactorID: "phone",
800805
},
801806
},
802807
}),
803808
map[string]interface{}{"mfaInfo": []*multiFactorInfoResponse{
804809
{
805810
PhoneInfo: "+11234567890",
806-
DisplayName: "Spouse's phone number",
811+
DisplayName: "Phone Number active",
812+
},
813+
{
814+
PhoneInfo: "+11234567890",
815+
DisplayName: "Phone Number deprecated",
807816
},
808817
},
809818
},

integration/auth/user_mgt_test.go

Lines changed: 21 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ import (
3030

3131
"firebase.google.com/go/v4/auth"
3232
"firebase.google.com/go/v4/auth/hash"
33+
"github.com/google/go-cmp/cmp"
3334
"google.golang.org/api/iterator"
3435
)
3536

@@ -433,11 +434,16 @@ func TestCreateUserMFA(t *testing.T) {
433434
tc.EmailVerified(true)
434435
tc.MFASettings(auth.MultiFactorSettings{
435436
EnrolledFactors: []*auth.MultiFactorInfo{
437+
{
438+
PhoneNumber: "+11234567890",
439+
DisplayName: "Phone Number deprecated",
440+
FactorID: "phone",
441+
},
436442
{
437443
PhoneMultiFactorInfo: &auth.PhoneMultiFactorInfo{
438-
PhoneNumber: "+11234567890",
444+
PhoneNumber: "+19876543210",
439445
},
440-
DisplayName: "Spouse's phone number",
446+
DisplayName: "Phone Number active",
441447
FactorID: "phone",
442448
},
443449
},
@@ -447,16 +453,25 @@ func TestCreateUserMFA(t *testing.T) {
447453
t.Fatalf("CreateUser() = %v; want = nil", err)
448454
}
449455
defer deleteUser(user.UID)
450-
var factor []*auth.MultiFactorInfo = []*auth.MultiFactorInfo{
456+
var factors []*auth.MultiFactorInfo = []*auth.MultiFactorInfo{
451457
{
452458
UID: user.MultiFactor.EnrolledFactors[0].UID,
453-
DisplayName: "Spouse's phone number",
459+
DisplayName: "Phone Number deprecated",
454460
FactorID: "phone",
455461
PhoneMultiFactorInfo: &auth.PhoneMultiFactorInfo{
456462
PhoneNumber: "+11234567890",
457463
},
458464
EnrollmentTimestamp: user.MultiFactor.EnrolledFactors[0].EnrollmentTimestamp,
459465
},
466+
{
467+
UID: user.MultiFactor.EnrolledFactors[1].UID,
468+
DisplayName: "Phone Number active",
469+
FactorID: "phone",
470+
PhoneMultiFactorInfo: &auth.PhoneMultiFactorInfo{
471+
PhoneNumber: "+19876543210",
472+
},
473+
EnrollmentTimestamp: user.MultiFactor.EnrolledFactors[1].EnrollmentTimestamp,
474+
},
460475
}
461476
want := auth.UserRecord{
462477
EmailVerified: true,
@@ -470,10 +485,11 @@ func TestCreateUserMFA(t *testing.T) {
470485
},
471486
TokensValidAfterMillis: user.TokensValidAfterMillis,
472487
MultiFactor: &auth.MultiFactorSettings{
473-
EnrolledFactors: factor,
488+
EnrolledFactors: factors,
474489
},
475490
}
476491
if !reflect.DeepEqual(*user, want) {
492+
fmt.Println(cmp.Diff(*user, want))
477493
t.Errorf("CreateUser() = %#v; want = %#v", *user, want)
478494
}
479495
}

0 commit comments

Comments
 (0)