Addressing feedback

Author: pragatimodi

auth/user_mgt.go

@@ -356,7 +356,7 @@ func (u *UserToUpdate) validatedRequest() (map[string]interface{}, error) {
 			if err != nil {
 				return nil, err
 			}
-			// https://cloud.google.com/identity-platform/docs/reference/rest/v1/accounts/update
+			// Request body ref: https://cloud.google.com/identity-platform/docs/reference/rest/v1/accounts/update
 			req["mfa"] = multiFactorEnrollments{mfaInfo}
 		} else {
 			req[k] = v

auth/user_mgt_test.go

@@ -69,7 +69,7 @@ var testUser = &UserRecord{
 	MultiFactor: &MultiFactorSettings{
 		EnrolledFactors: []*MultiFactorInfo{
 			{
-				UID:                 "enrolledFactor1",
+				UID:                 "enrolledPhoneFactor",
 				FactorID:            "phone",
 				EnrollmentTimestamp: 1614776780000,
 				PhoneMultiFactorInfo: &PhoneMultiFactorInfo{
@@ -78,7 +78,7 @@ var testUser = &UserRecord{
 				DisplayName: "My MFA Phone",
 			},
 			{
-				UID:                 "enrolledFactor2",
+				UID:                 "enrolledTOTPFactor",
 				FactorID:            "totp",
 				EnrollmentTimestamp: 1614776780000,
 				TOTPMultiFactorInfo: &TOTPInfo{},
@@ -1918,13 +1918,13 @@ func TestMakeExportedUser(t *testing.T) {
 		MFAInfo: []*multiFactorInfoResponse{
 			{
 				PhoneInfo:       "+1234567890",
-				MFAEnrollmentID: "enrolledFactor1",
+				MFAEnrollmentID: "enrolledPhoneFactor",
 				DisplayName:     "My MFA Phone",
 				EnrolledAt:      "2021-03-03T13:06:20.542896Z",
 			},
 			{
 				TOTPInfo:        &TOTPInfo{},
-				MFAEnrollmentID: "enrolledFactor2",
+				MFAEnrollmentID: "enrolledTOTPFactor",
 				DisplayName:     "My MFA TOTP",
 				EnrolledAt:      "2021-03-03T13:06:20.542896Z",
 			},

testdata/get_user.json

@@ -35,17 +35,17 @@
       "mfaInfo": [
         {
           "phoneInfo": "+1234567890",
-          "mfaEnrollmentId": "enrolledFactor1",
+          "mfaEnrollmentId": "enrolledPhoneFactor",
           "displayName": "My MFA Phone",
           "enrolledAt": "2021-03-03T13:06:20.542896Z"
         },
         {
           "totpInfo": {},
-          "mfaEnrollmentId": "enrolledFactor2",
+          "mfaEnrollmentId": "enrolledTOTPFactor",
           "displayName": "My MFA TOTP",
           "enrolledAt": "2021-03-03T13:06:20.542896Z"
         }
       ]
     }
   ]
-}
+}

testdata/list_users.json

@@ -35,13 +35,13 @@
             "mfaInfo": [
                 {
                     "phoneInfo": "+1234567890",
-                    "mfaEnrollmentId": "enrolledFactor1",
+                    "mfaEnrollmentId": "enrolledPhoneFactor",
                     "displayName": "My MFA Phone",
                     "enrolledAt": "2021-03-03T13:06:20.542896Z"
                 },
                 {
                     "totpInfo": {},
-                    "mfaEnrollmentId": "enrolledFactor2",
+                    "mfaEnrollmentId": "enrolledTOTPFactor",
                     "displayName": "My MFA TOTP",
                     "enrolledAt": "2021-03-03T13:06:20.542896Z"
                 }
@@ -81,13 +81,13 @@
             "mfaInfo": [
                 {
                     "phoneInfo": "+1234567890",
-                    "mfaEnrollmentId": "enrolledFactor1",
+                    "mfaEnrollmentId": "enrolledPhoneFactor",
                     "displayName": "My MFA Phone",
                     "enrolledAt": "2021-03-03T13:06:20.542896Z"
                 },
                 {
                     "totpInfo": {},
-                    "mfaEnrollmentId": "enrolledFactor2",
+                    "mfaEnrollmentId": "enrolledTOTPFactor",
                     "displayName": "My MFA TOTP",
                     "enrolledAt": "2021-03-03T13:06:20.542896Z"
                 }
@@ -127,4 +127,4 @@
         }
     ],
     "nextPageToken": ""
-}
+}