Skip to content

Commit a3be682

Browse files
authored
[tests] remove pretest compiler script (#33452)
This shouldn't be needed now that the lint rule was move
1 parent b175988 commit a3be682

File tree

3 files changed

+30
-1
lines changed

3 files changed

+30
-1
lines changed

.github/workflows/runtime_build_and_test.yml

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -280,6 +280,35 @@ jobs:
280280
if: steps.node_modules.outputs.cache-hit != 'true'
281281
- run: yarn test ${{ matrix.params }} --ci --shard=${{ matrix.shard }}
282282

283+
# Hardcoded to improve parallelism
284+
test-linter:
285+
name: Test eslint-plugin-react-hooks
286+
needs: [runtime_compiler_node_modules_cache]
287+
runs-on: ubuntu-latest
288+
steps:
289+
- uses: actions/checkout@v4
290+
- uses: actions/setup-node@v4
291+
with:
292+
node-version-file: '.nvmrc'
293+
cache: yarn
294+
cache-dependency-path: |
295+
yarn.lock
296+
compiler/yarn.lock
297+
- name: Restore cached node_modules
298+
uses: actions/cache@v4
299+
id: node_modules
300+
with:
301+
path: |
302+
**/node_modules
303+
key: runtime-and-compiler-node_modules-v6-${{ runner.arch }}-${{ runner.os }}-${{ hashFiles('yarn.lock', 'compiler/yarn.lock') }}
304+
restore-keys: |
305+
runtime-and-compiler-node_modules-v6-${{ runner.arch }}-${{ runner.os }}-
306+
runtime-and-compiler-node_modules-v6-
307+
- run: yarn install --frozen-lockfile
308+
if: steps.node_modules.outputs.cache-hit != 'true'
309+
- run: ./scripts/react-compiler/build-compiler.sh && ./scripts/react-compiler/link-compiler.sh
310+
- run: yarn workspace eslint-plugin-react-hooks test
311+
283312
# ----- BUILD -----
284313
build_and_lint:
285314
name: yarn build and lint

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,6 @@
129129
"lint-build": "node ./scripts/rollup/validate/index.js",
130130
"extract-errors": "node scripts/error-codes/extract-errors.js",
131131
"postinstall": "node ./scripts/flow/createFlowConfigs.js",
132-
"pretest": "./scripts/react-compiler/build-compiler.sh && ./scripts/react-compiler/link-compiler.sh",
133132
"test": "node ./scripts/jest/jest-cli.js",
134133
"test-stable": "node ./scripts/jest/jest-cli.js --release-channel=stable",
135134
"test-www": "node ./scripts/jest/jest-cli.js --release-channel=www-modern",

scripts/jest/config.base.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ module.exports = {
55
modulePathIgnorePatterns: [
66
'<rootDir>/scripts/rollup/shims/',
77
'<rootDir>/scripts/bench/',
8+
'<rootDir>/packages/eslint-plugin-react-hooks/',
89
],
910
transform: {
1011
'^.+babel-plugin-react-compiler/dist/index.js$': [

0 commit comments

Comments
 (0)