Nvm, keep it as disableSchedulerTimeoutInWorkLoop

rickhanlonii · rickhanlonii · commit 3d502d2495b1 · 2020-12-17T17:04:25.000-05:00
diff --git a/packages/react-reconciler/src/ReactFiberWorkLoop.new.js b/packages/react-reconciler/src/ReactFiberWorkLoop.new.js
@@ -31,7 +31,7 @@ import {
   enableDebugTracing,
   enableSchedulingProfiler,
   enableScopeAPI,
-  enableSchedulerTimeoutInWorkLoop,
+  disableSchedulerTimeoutInWorkLoop,
 } from 'shared/ReactFeatureFlags';
 import ReactSharedInternals from 'shared/ReactSharedInternals';
 import invariant from 'shared/invariant';
@@ -833,7 +833,7 @@ function performConcurrentWorkOnRoot(root, didTimeout) {
                                                          // bug we're still investigating. Once the bug in Scheduler is fixed,
                                                          // we can remove this, since we track expiration ourselves.
                                                          if (
-                                                           enableSchedulerTimeoutInWorkLoop &&
+                                                           disableSchedulerTimeoutInWorkLoop &&
                                                            didTimeout
                                                          ) {
                                                            // Something expired. Flush synchronously until there's no expired
diff --git a/packages/react-reconciler/src/ReactFiberWorkLoop.old.js b/packages/react-reconciler/src/ReactFiberWorkLoop.old.js
@@ -33,7 +33,7 @@ import {
   enableSchedulingProfiler,
   enableScopeAPI,
   enableDoubleInvokingEffects,
-  enableSchedulerTimeoutInWorkLoop,
+  disableSchedulerTimeoutInWorkLoop,
 } from 'shared/ReactFeatureFlags';
 import ReactSharedInternals from 'shared/ReactSharedInternals';
 import invariant from 'shared/invariant';
@@ -841,7 +841,7 @@ function performConcurrentWorkOnRoot(root, didTimeout) {
                                                          // bug we're still investigating. Once the bug in Scheduler is fixed,
                                                          // we can remove this, since we track expiration ourselves.
                                                          if (
-                                                           enableSchedulerTimeoutInWorkLoop &&
+                                                           disableSchedulerTimeoutInWorkLoop &&
                                                            didTimeout
                                                          ) {
                                                            // Something expired. Flush synchronously until there's no expired
diff --git a/packages/shared/ReactFeatureFlags.js b/packages/shared/ReactFeatureFlags.js
@@ -142,4 +142,4 @@ export const enableUseRefAccessWarning = false;
 
 export const enableRecursiveCommitTraversal = false;
 
-export const enableSchedulerTimeoutInWorkLoop = false;
+export const disableSchedulerTimeoutInWorkLoop = false;
diff --git a/packages/shared/forks/ReactFeatureFlags.native-fb.js b/packages/shared/forks/ReactFeatureFlags.native-fb.js
@@ -56,7 +56,7 @@ export const enableDoubleInvokingEffects = false;
 export const enableUseRefAccessWarning = false;
 
 export const enableRecursiveCommitTraversal = false;
-export const enableSchedulerTimeoutInWorkLoop = false;
+export const disableSchedulerTimeoutInWorkLoop = false;
 
 // Flow magic to verify the exports of this file match the original version.
 // eslint-disable-next-line no-unused-vars
diff --git a/packages/shared/forks/ReactFeatureFlags.native-oss.js b/packages/shared/forks/ReactFeatureFlags.native-oss.js
@@ -55,7 +55,7 @@ export const enableDoubleInvokingEffects = false;
 export const enableUseRefAccessWarning = false;
 
 export const enableRecursiveCommitTraversal = false;
-export const enableSchedulerTimeoutInWorkLoop = false;
+export const disableSchedulerTimeoutInWorkLoop = false;
 
 // Flow magic to verify the exports of this file match the original version.
 // eslint-disable-next-line no-unused-vars
diff --git a/packages/shared/forks/ReactFeatureFlags.test-renderer.js b/packages/shared/forks/ReactFeatureFlags.test-renderer.js
@@ -55,7 +55,7 @@ export const enableDoubleInvokingEffects = false;
 export const enableUseRefAccessWarning = false;
 
 export const enableRecursiveCommitTraversal = false;
-export const enableSchedulerTimeoutInWorkLoop = false;
+export const disableSchedulerTimeoutInWorkLoop = false;
 
 // Flow magic to verify the exports of this file match the original version.
 // eslint-disable-next-line no-unused-vars
diff --git a/packages/shared/forks/ReactFeatureFlags.test-renderer.native.js b/packages/shared/forks/ReactFeatureFlags.test-renderer.native.js
@@ -55,7 +55,7 @@ export const enableDoubleInvokingEffects = false;
 export const enableUseRefAccessWarning = false;
 
 export const enableRecursiveCommitTraversal = false;
-export const enableSchedulerTimeoutInWorkLoop = false;
+export const disableSchedulerTimeoutInWorkLoop = false;
 
 // Flow magic to verify the exports of this file match the original version.
 // eslint-disable-next-line no-unused-vars
diff --git a/packages/shared/forks/ReactFeatureFlags.test-renderer.www.js b/packages/shared/forks/ReactFeatureFlags.test-renderer.www.js
@@ -55,7 +55,7 @@ export const enableDoubleInvokingEffects = true;
 export const enableUseRefAccessWarning = false;
 
 export const enableRecursiveCommitTraversal = false;
-export const enableSchedulerTimeoutInWorkLoop = false;
+export const disableSchedulerTimeoutInWorkLoop = false;
 
 // Flow magic to verify the exports of this file match the original version.
 // eslint-disable-next-line no-unused-vars
diff --git a/packages/shared/forks/ReactFeatureFlags.testing.js b/packages/shared/forks/ReactFeatureFlags.testing.js
@@ -55,7 +55,7 @@ export const enableDoubleInvokingEffects = false;
 export const enableUseRefAccessWarning = false;
 
 export const enableRecursiveCommitTraversal = false;
-export const enableSchedulerTimeoutInWorkLoop = false;
+export const disableSchedulerTimeoutInWorkLoop = false;
 
 // Flow magic to verify the exports of this file match the original version.
 // eslint-disable-next-line no-unused-vars
diff --git a/packages/shared/forks/ReactFeatureFlags.testing.www.js b/packages/shared/forks/ReactFeatureFlags.testing.www.js
@@ -55,7 +55,7 @@ export const enableDoubleInvokingEffects = false;
 export const enableUseRefAccessWarning = false;
 
 export const enableRecursiveCommitTraversal = false;
-export const enableSchedulerTimeoutInWorkLoop = false;
+export const disableSchedulerTimeoutInWorkLoop = false;
 
 // Flow magic to verify the exports of this file match the original version.
 // eslint-disable-next-line no-unused-vars
diff --git a/packages/shared/forks/ReactFeatureFlags.www-dynamic.js b/packages/shared/forks/ReactFeatureFlags.www-dynamic.js
@@ -53,4 +53,4 @@ export const enableDoubleInvokingEffects = false;
 export const enableUseRefAccessWarning = __VARIANT__;
 
 export const enableProfilerNestedUpdateScheduledHook = __VARIANT__;
-export const enableSchedulerTimeoutInWorkLoop = __VARIANT__;
+export const disableSchedulerTimeoutInWorkLoop = __VARIANT__;
diff --git a/packages/shared/forks/ReactFeatureFlags.www.js b/packages/shared/forks/ReactFeatureFlags.www.js
@@ -15,22 +15,22 @@ import typeof * as DynamicFeatureFlags from './ReactFeatureFlags.www-dynamic';
 const dynamicFeatureFlags: DynamicFeatureFlags = require('ReactFeatureFlags');
 
 export const {
-         debugRenderPhaseSideEffectsForStrictMode,
-         disableInputAttributeSyncing,
-         enableTrustedTypesIntegration,
-         disableSchedulerTimeoutBasedOnReactExpirationTime,
-         warnAboutSpreadingKeyToJSX,
-         replayFailedUnitOfWorkWithInvokeGuardedCallback,
-         enableFilterEmptyStringAttributesDOM,
-         enableLegacyFBSupport,
-         deferRenderPhaseUpdateToNextBatch,
-         decoupleUpdatePriorityFromScheduler,
-         enableDebugTracing,
-         enableDoubleInvokingEffects,
-         enableUseRefAccessWarning,
-         disableNativeComponentFrames,
-         enableSchedulerTimeoutInWorkLoop,
-       } = dynamicFeatureFlags;
+  debugRenderPhaseSideEffectsForStrictMode,
+  disableInputAttributeSyncing,
+  enableTrustedTypesIntegration,
+  disableSchedulerTimeoutBasedOnReactExpirationTime,
+  warnAboutSpreadingKeyToJSX,
+  replayFailedUnitOfWorkWithInvokeGuardedCallback,
+  enableFilterEmptyStringAttributesDOM,
+  enableLegacyFBSupport,
+  deferRenderPhaseUpdateToNextBatch,
+  decoupleUpdatePriorityFromScheduler,
+  enableDebugTracing,
+  enableDoubleInvokingEffects,
+  enableUseRefAccessWarning,
+  disableNativeComponentFrames,
+  disableSchedulerTimeoutInWorkLoop,
+} = dynamicFeatureFlags;
 
 // On WWW, __EXPERIMENTAL__ is used for a new modern build.
 // It's not used anywhere in production yet.

Original file line number	Diff line number	Diff line change
`@@ -142,4 +142,4 @@ export const enableUseRefAccessWarning = false;`
`142`	`142`
`143`	`143`	`export const enableRecursiveCommitTraversal = false;`
`144`	`144`
`145`		`-export const enableSchedulerTimeoutInWorkLoop = false;`
	`145`	`+export const disableSchedulerTimeoutInWorkLoop = false;`