Merge branch 'main' into patch-2

Author: billnbell3

.flowconfig

@@ -78,4 +78,4 @@ untyped-import
 untyped-type-import
 
 [version]
-^0.211.0
+^0.212.0

.flowconfig.android

@@ -78,4 +78,4 @@ untyped-import
 untyped-type-import
 
 [version]
-^0.211.0
+^0.212.0

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -38,9 +38,9 @@ body:
   - type: textarea
     id: extra
     attributes:
-      label: Snack, code example, screenshot, or link to a repository
+      label: Snack, screenshot, or link to a repository
       description: |
-        Please provide a Snack (https://snack.expo.dev/), a link to a repository on GitHub, or provide a minimal code example that reproduces the problem.
+        Please provide a Snack (https://snack.expo.dev/), a link to a repository on GitHub that reproduces the problem.
         You may provide a screenshot of the application if you think it is relevant to your bug report.
         Here are some tips for providing a minimal example: https://stackoverflow.com/help/mcve
         Please note that a reproducer is **mandatory**. Issues without reproducer are more likely to stall and will be closed.

.github/workflow-scripts/actOnLabel.js

@@ -121,7 +121,7 @@ module.exports = async (github, context, labelWithContext) => {
       await addComment(
         `| :warning: | Missing Reproducible Example |\n` +
           `| --- | --- |\n` +
-          `| :information_source: | It looks like your issue is missing a reproducible example. Please provide either: <br /><ul><li>If your bug is UI related: a [Snack](https://snack.expo.dev)</li><li> If your bug is build/update related: use our [Reproducer Template](https://github.com/react-native-community/reproducer-react-native/generate)</li></ul> |`,
+          `| :information_source: | We could not detect a reproducible example in your issue report. Please provide either: <br /><ul><li>If your bug is UI related: a [Snack](https://snack.expo.dev)</li><li> If your bug is build/update related: use our [Reproducer Template](https://github.com/react-native-community/reproducer-react-native/generate)</li></ul> |`,
       );
       await requestAuthorFeedback();
       return;
@@ -133,5 +133,16 @@ module.exports = async (github, context, labelWithContext) => {
       );
       await requestAuthorFeedback();
       return;
+    case 'Type: Too Old Version':
+      await addComment(
+        `| :warning: | Too Old Version of React Native |\n` +
+          `| --- | --- |\n` +
+          `| :information_source: | It looks like your issue or the example you provided uses a [**Too Old Version of React Native**](https://github.com/reactwg/react-native-releases/blob/main/README.md#releases-support-policy).\nDue to the number of issues we receive, we're currently only accepting new issues against one of the supported versions. Please [upgrade](https://reactnative.dev/docs/upgrading) to latest and verify if the issue persists (alternatively, create a new project and repro the issue in it). If you cannot upgrade, please open your issue on [StackOverflow](https://stackoverflow.com/questions/tagged/react-native) to get further community support. |`,
+      );
+      await closeIssue();
+      return;
+    default:
+      // No action needed
+      return;
   }
 };

.github/workflow-scripts/checkForReproducer.js

@@ -0,0 +1,110 @@
+/**
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ *
+ * @format
+ */
+
+const NEEDS_REPRO_LABEL = 'Needs: Repro';
+const NEEDS_REPRO_HEADER = 'Missing Reproducible Example';
+const NEEDS_REPRO_MESSAGE =
+  `| :warning: | Missing Reproducible Example |\n` +
+  `| --- | --- |\n` +
+  `| :information_source: | We could not detect a reproducible example in your issue report. Please provide either: <br /><ul><li>If your bug is UI related: a [Snack](https://snack.expo.dev)</li><li> If your bug is build/update related: use our [Reproducer Template](https://github.com/react-native-community/reproducer-react-native/generate). A reproducer needs to be in a GitHub repository under your username.</li></ul> |`;
+
+module.exports = async (github, context) => {
+  const issueData = {
+    issue_number: context.payload.issue.number,
+    owner: context.repo.owner,
+    repo: context.repo.repo,
+  };
+
+  const issue = await github.rest.issues.get(issueData);
+  const comments = await github.rest.issues.listComments(issueData);
+
+  const author = issue.data.user.login;
+
+  const maintainerChangedLabel = await hasMaintainerChangedLabel(
+    github,
+    issueData,
+    author,
+  );
+
+  if (maintainerChangedLabel) {
+    return;
+  }
+
+  const botComment = comments.data.find(comment =>
+    comment.body.includes(NEEDS_REPRO_HEADER),
+  );
+
+  const entities = [issue.data, ...comments.data];
+
+  // Look for Snack or a GH repo associated with the user that added an issue or comment
+  const hasValidReproducer = entities.some(entity => {
+    const hasExpoSnackLink = containsPattern(
+      entity.body,
+      `https?:\\/\\/snack\\.expo\\.dev\\/[^\\s)\\]]+`,
+    );
+
+    const hasGithubRepoLink = containsPattern(
+      entity.body,
+      `https?:\\/\\/github\\.com\\/(${entity.user.login})\\/[^/]+\\/?\\s?`,
+    );
+    return hasExpoSnackLink || hasGithubRepoLink;
+  });
+
+  if (hasValidReproducer) {
+    try {
+      await github.rest.issues.removeLabel({
+        ...issueData,
+        name: NEEDS_REPRO_LABEL,
+      });
+    } catch (error) {
+      if (!/Label does not exist/.test(error.message)) {
+        throw error;
+      }
+    }
+
+    if (!botComment) return;
+
+    await github.rest.issues.deleteComment({
+      ...issueData,
+      comment_id: botComment.id,
+    });
+  } else {
+    await github.rest.issues.addLabels({
+      ...issueData,
+      labels: [NEEDS_REPRO_LABEL],
+    });
+
+    if (botComment) return;
+
+    await github.rest.issues.createComment({
+      ...issueData,
+      body: NEEDS_REPRO_MESSAGE,
+    });
+  }
+};
+
+function containsPattern(body, pattern) {
+  const regexp = new RegExp(pattern, 'gm');
+  return body.search(regexp) !== -1;
+}
+
+// Prevents the bot from responding when maintainer has changed Needs: Repro the label
+async function hasMaintainerChangedLabel(github, issueData, author) {
+  const timeline = await github.rest.issues.listEventsForTimeline(issueData);
+
+  const labeledEvents = timeline.data.filter(
+    event => event.event === 'labeled' || event.event === 'unlabeled',
+  );
+  const userEvents = labeledEvents.filter(event => event.actor.type !== 'Bot');
+
+  return userEvents.some(
+    event =>
+      event.actor.login !== author && event.label.name === NEEDS_REPRO_LABEL,
+  );
+}

.github/workflow-scripts/verifyVersion.js

@@ -42,6 +42,11 @@ module.exports = async (github, context) => {
   ).data;
   const latestVersion = parseVersionFromString(latestRelease.name);
 
+  // We want to "insta-close" an issue if RN version provided is too old. And encourage users to upgrade.
+  if (isVersionTooOld(issueVersion, latestVersion)) {
+    return {label: 'Type: Too Old Version'};
+  }
+
   if (!isVersionSupported(issueVersion, latestVersion)) {
     return {label: 'Type: Unsupported Version'};
   }
@@ -59,14 +64,34 @@ module.exports = async (github, context) => {
   }
 };
 
-// We support N-2 minor versions, and the latest major.
+/**
+ * Check if the RN version provided in an issue is supported.
+ *
+ * "We support `N-2` minor versions, and the `latest` major".
+ */
 function isVersionSupported(actualVersion, latestVersion) {
   return (
     actualVersion.major >= latestVersion.major &&
     actualVersion.minor >= latestVersion.minor - 2
   );
 }
 
+/**
+ * Check if the RN version provided in an issue is too old.
+ * "We support `N-2` minor versions, and the `latest` major".
+ *
+ * A RN version is *too old* if it's:
+ * - `1` or more *major* behind the *latest major*.
+ * - `5` or more *minor* behind the *latest minor* in the *same major*. Less aggressive.
+ *   (e.g. If `0.72.0` is the current latest then `0.67.0` and lower is too old for `0.72.0`)
+ */
+function isVersionTooOld(actualVersion, latestVersion) {
+  return (
+    latestVersion.major - actualVersion.major >= 1 ||
+    latestVersion.minor - actualVersion.minor >= 5
+  );
+}
+
 // Assumes that releases are sorted in the order of recency (i.e. most recent releases are earlier in the list)
 // This enables us to stop looking as soon as we find the first release with a matching major/minor version, since
 // we know it's the most recent release, therefore the highest patch available.

.github/workflows/check-for-reproducer.yml

@@ -0,0 +1,21 @@
+name: Check for reproducer
+# This workflow is triggered when issue is created or edited.
+# Also, when a comment is added, edited or deleted.
+on:
+  issues:
+    types: [opened, edited]
+  issue_comment:
+    types: [created, edited, deleted]
+
+jobs:
+  check-for-reproducer:
+    runs-on: ubuntu-latest
+    if: github.repository == 'facebook/react-native' && github.event.issue.pull_request == null && github.event.issue.state == 'open'
+    steps:
+      - uses: actions/checkout@v3
+      - uses: actions/github-script@v6
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          script: |
+            const checkForReproducer = require('./.github/workflow-scripts/checkForReproducer.js')
+            await checkForReproducer(github, context)

CHANGELOG.md

@@ -2,6 +2,49 @@
 
 This file contains all changelogs for latest releases, from 0.70.0 onward. Please check out the other `CHANGELOG-*.md` files for previous versions.
 
+## v0.72.3
+
+### Fixed
+
+#### iOS specific
+
+- Revert "Fix pod install for swift libs using new arch (#38121)" to fix [build error with Xcode lower than Xcode 14.3](https://github.com/facebook/react-native/issues/38294) ([8f41f25](https://github.com/facebook/react-native/commit/8f41f25c214f995073e90b786c805eb45ff7dee5) by [@kelset](https://github.com/kelset))
+
+## v0.72.2
+
+### Changed
+
+- Remove deprecated stub types `@types/metro-config` from template ([63f78ea8de](https://github.com/facebook/react-native/commit/63f78ea8de68688005e7f48c6849bdf9f95e26ff) by [@kelset](https://github.com/kelset))
+- Bump CLI to 11.3.5 and Metro do 0.76.7 ([ba5fa9c394](https://github.com/facebook/react-native/commit/ba5fa9c394e7cd127e3ee543e0716c37912b0b40) by [@kelset](https://github.com/kelset))
+- Bump `@react-native/metro-config` to `0.72.9` ([21daa6e790](https://github.com/facebook/react-native/commit/21daa6e79030574ce41665ea13c39316eac8c305), [f37386176](https://github.com/facebook/react-native/commit/f37386176cb081e7b38fad8b5442099598bf1968)  by [@kelset](https://github.com/kelset))
+
+#### Android specific
+
+- Remove okhttp3 internal util usage ([3e3032636d](https://github.com/facebook/react-native/commit/3e3032636dc90a21a499492dcb88f819bcf4f003) by [@adrianha](https://github.com/adrianha))
+
+#### iOS specific
+
+- Update logic to add and remove views in the view registry for the interop layer. ([8d2eec367d](https://github.com/facebook/react-native/commit/8d2eec367dd6fbd60792ca1bde12b875a8261fa6) by [@cipolleschi](https://github.com/cipolleschi))
+- Disable NSTextStorage caching in OSS ([5bda54c1f1](https://github.com/facebook/react-native/commit/5bda54c1f183fbc51dc7264b0ab94d5bbcc3f172) by [@sammy-SC](https://github.com/sammy-SC))
+
+### Fixed
+
+- `global.performance` in undefined when starting metro from Expo CLI ([0ccbd65581](https://github.com/facebook/react-native/commit/0ccbd65581304faa286b452f75058b6292a6240f) by [@Kudo](https://github.com/Kudo))
+- Re-enabled debugging for debug builds ([41477c898c](https://github.com/facebook/react-native/commit/41477c898cf5726eae9edbb1596366a6eea2b01e) by Matt Blagden)
+- Add global hook to assert that base Metro config is called ([29f2602ff9](https://github.com/facebook/react-native/commit/29f2602ff9c3c9a9999c54a6004c99d6fd15ebc3) by [@huntie](https://github.com/huntie))
+
+#### Android specific
+
+- Do not create RuntimeExecutor on non-JSI executors (#38125) ([d73b61c7c7](https://github.com/facebook/react-native/commit/d73b61c7c7dae23630b51b00048eafe5fcb47bd3) by [@lunaleaps](https://github.com/lunaleaps))
+- Prevent crash on OnePlus/Oppo devices in runAnimationStep ([a46a7cd1](https://github.com/facebook/react-native/commit/a46a7cd1f613d6eaea1d1cd07751f17cdc07c21b) by [@hsource](https://github.com/hsource))
+
+#### iOS specific
+
+- Fix build error when there are multiple EXTRA_COMPILER_ARGS ([28f4ebab8a](https://github.com/facebook/react-native/commit/28f4ebab8ab4b0f337699e6a135e2aa983866f42) by [@fergusean](https://github.com/fergusean))
+- Build failure with pnpm and use_frameworks! due to incorrect header paths ([58adc5e4b9](https://github.com/facebook/react-native/commit/58adc5e4b9ab74b67b4af04d1e72c387af848ea7) by evelant)
+- Fix onChangeText not firing when clearing the value of TextInput with multiline=true on iOS ([0c9c57a9f7](https://github.com/facebook/react-native/commit/0c9c57a9f73294414d92428c5d2472dc1e1e5e96) by [@kkoudev](https://github.com/kkoudev))
+- Fix pod install for libraries using Swift code when the new architecture is enabled ([a4a0655496](https://github.com/facebook/react-native/commit/a4a065549677c61eb91bf587032976ed48c75821) by [@louiszawadzki](https://github.com/louiszawadzki))
+
 ## v0.72.1
 
 ### Added

flow-typed/npm/babel-traverse_v7.x.x.js

@@ -324,7 +324,7 @@ declare module '@babel/traverse' {
 
     parentKey: string;
     scope: Scope;
-    type: null | $PropertyType<BabelNode, 'type'>;
+    type: null | BabelNode['type'];
     inList: boolean;
     typeAnnotation?: BabelNodeTypeAnnotation;
 
@@ -429,7 +429,7 @@ declare module '@babel/traverse' {
      */
     isDescendant(maybeAncestor: NodePath<>): boolean;
 
-    inType(...candidateTypes: Array<$PropertyType<BabelNode, 'type'>>): boolean;
+    inType(...candidateTypes: Array<BabelNode['type']>): boolean;
 
     // _inference
 
@@ -585,7 +585,7 @@ declare module '@babel/traverse' {
      * Check the type against our stored internal type of the node. This is handy when a node has
      * been removed yet we still internally know the type and need it to calculate node replacement.
      */
-    isNodeType(type: $PropertyType<BabelNode, 'type'>): boolean;
+    isNodeType(type: BabelNode['type']): boolean;
 
     /**
      * This checks whether or not we're in one of the following positions:

flow-typed/npm/babel_v7.x.x.js

@@ -10,8 +10,6 @@
 
 'use strict';
 
-declare type BabelNode_DEPRECATED = any;
-
 type _BabelSourceMap = $ReadOnly<{
   file?: string,
   mappings: string,
@@ -833,7 +831,7 @@ declare module '@babel/core' {
      */
     wrapPluginVisitorMethod?: (
       key: string,
-      nodeType: $PropertyType<BabelNode, 'type'>,
+      nodeType: BabelNode['type'],
       fn: Function,
     ) => Function,