Skip to content

Commit 07a48c2

Browse files
committed
Parse error stack on LogBoxData
1 parent 352ab9f commit 07a48c2

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

packages/react-native/Libraries/LogBox/Data/LogBoxData.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
('use strict');
1212
import type {ExtendedError} from '../../Core/ExtendedError';
1313
import type {LogLevel} from './LogBoxLog';
14-
import type {Stack} from './LogBoxSymbolication';
1514
import type {
1615
Category,
1716
ComponentStack,
@@ -30,7 +29,7 @@ export type LogData = $ReadOnly<{|
3029
message: Message,
3130
category: Category,
3231
componentStack: ComponentStack,
33-
stack?: Stack,
32+
stack?: string,
3433
|}>;
3534

3635
export type Observer = (
@@ -199,7 +198,7 @@ export function addLog(log: LogData): void {
199198
// otherwise spammy logs would pause rendering.
200199
setImmediate(() => {
201200
try {
202-
const stack = log.stack ?? parseErrorStack(errorForStackTrace?.stack);
201+
const stack = parseErrorStack(log.stack ?? errorForStackTrace?.stack);
203202

204203
appendNewLog(
205204
new LogBoxLog({

packages/react-native/Libraries/promiseRejectionTrackingOptions.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010

1111
import typeof {enable} from 'promise/setimmediate/rejection-tracking';
1212

13-
const parseErrorStack = require('./Core/Devtools/parseErrorStack');
1413
const LogBox = require('./LogBox/LogBox').default;
1514

1615
let rejectionTrackingOptions: $NonMaybeType<Parameters<enable>[0]> = {
@@ -33,13 +32,11 @@ let rejectionTrackingOptions: $NonMaybeType<Parameters<enable>[0]> = {
3332

3433
// Print pretty unhandled rejections while on DEV
3534
if (__DEV__) {
36-
const parsedStack = parseErrorStack(error.stack);
37-
3835
LogBox.addLog({
3936
level: 'warn',
4037
message: {content: warning, substitutions: []},
4138
componentStack: [],
42-
stack: parsedStack,
39+
stack: error.stack,
4340
category: 'possible_unhandled_promise_rejection',
4441
});
4542

0 commit comments

Comments
 (0)