Skip to content

Commit 0061bea

Browse files
cipolleschilunaleaps
authored andcommitted
Fix RCTFabric podspec (#42639)
Summary: Pull Request resolved: #42639 When I reverted part of the deprecation of `RCT_NEW_ARCH_ENABLED`, I forget a little bit which was breaking RCTFabric podspec. This diff fixes that. [Internal] - Bring back `RCT_NEW_ARCH_ENABLED` to Fabric to make the `RCTThirdPartyFabricComponentsProvider` work again. Reviewed By: cortinico Differential Revision: D53048270 fbshipit-source-id: d21e833c10b332fb70147cc65b690f88016655e6
1 parent 3bdd54a commit 0061bea

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

packages/react-native/React/React-RCTFabric.podspec

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ folly_flags = '-DFOLLY_NO_CONFIG -DFOLLY_MOBILE=1 -DFOLLY_USE_LIBCPP=1 -DFOLLY_C
2020
folly_compiler_flags = folly_flags + ' ' + '-Wno-comma -Wno-shorten-64-to-32'
2121
folly_version = '2022.05.16.00'
2222
boost_compiler_flags = '-Wno-documentation'
23+
new_arch_flags = ENV['RCT_NEW_ARCH_ENABLED'] == '1' ? ' -DRCT_NEW_ARCH_ENABLED=1' : ''
2324

2425
header_search_paths = [
2526
"\"$(PODS_TARGET_SRCROOT)/ReactCommon\"",
@@ -52,13 +53,13 @@ Pod::Spec.new do |s|
5253
s.source_files = "Fabric/**/*.{c,h,m,mm,S,cpp}"
5354
s.exclude_files = "**/tests/*",
5455
"**/android/*",
55-
s.compiler_flags = folly_compiler_flags + ' ' + boost_compiler_flags
56+
s.compiler_flags = folly_compiler_flags + ' ' + boost_compiler_flags + new_arch_flags
5657
s.header_dir = header_dir
5758
s.module_name = module_name
5859
s.framework = ["JavaScriptCore", "MobileCoreServices"]
5960
s.pod_target_xcconfig = {
6061
"HEADER_SEARCH_PATHS" => header_search_paths,
61-
"OTHER_CFLAGS" => "$(inherited) -DRN_FABRIC_ENABLED" + " " + folly_flags,
62+
"OTHER_CFLAGS" => "$(inherited) -DRN_FABRIC_ENABLED" + " " + folly_flags + new_arch_flags,
6263
"CLANG_CXX_LANGUAGE_STANDARD" => "c++20"
6364
}.merge!(ENV['USE_FRAMEWORKS'] != nil ? {
6465
"PUBLIC_HEADERS_FOLDER_PATH" => "#{module_name}.framework/Headers/#{header_dir}"

0 commit comments

Comments
 (0)