Skip to content

Commit 3fb6b65

Browse files
committed
Update Welcome docs links for launch
- Substitute "React DevTools" guide for incoming "React Native DevTools" page (note: URL will be changed later via redirect) - Fix `/docs/debugging-native-code` link
1 parent 87b2feb commit 3fb6b65

File tree

4 files changed

+8
-11
lines changed

4 files changed

+8
-11
lines changed

config/gni/devtools_grd_files.gni

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,6 @@ grd_files_release_sources = [
191191
"front_end/Images/profile.svg",
192192
"front_end/Images/react_native/learn-debugging-basics.jpg",
193193
"front_end/Images/react_native/learn-native-debugging.jpg",
194-
"front_end/Images/react_native/learn-react-devtools.jpg",
195194
"front_end/Images/react_native/learn-react-native-devtools.jpg",
196195
"front_end/Images/react_native/welcomeIcon.png",
197196
"front_end/Images/record-start.svg",

config/gni/devtools_image_files.gni

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ devtools_image_files = [
1818
"popoverArrows.png",
1919
"react_native/learn-debugging-basics.jpg",
2020
"react_native/learn-native-debugging.jpg",
21-
"react_native/learn-react-devtools.jpg",
2221
"react_native/learn-react-native-devtools.jpg",
2322
"react_native/welcomeIcon.png",
2423
"toolbarResizerVertical.png",
-71.5 KB
Binary file not shown.

front_end/panels/rn_welcome/RNWelcome.ts

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,10 @@ const UIStrings = {
2929
docsDebuggingBasics: 'Debugging Basics',
3030
/** @description "Debugging Basics" item detail */
3131
docsDebuggingBasicsDetail: 'Overview of debugging tools in React Native',
32-
/** @description "React DevTools" title (docs item 2 - pre-launch) */
33-
docsReactDevTools: 'React DevTools',
34-
/** @description "React DevTools" item detail */
35-
docsReactDevToolsDetail: 'Debug React components with React DevTools',
32+
/** @description "React Native DevTools" title (docs item 2) */
33+
docsReactNativeDevTools: 'React Native DevTools',
34+
/** @description "React Native DevTools" item detail */
35+
docsReactDevToolsDetail: 'Explore features available in React Native DevTools',
3636
/** @description "Native Debugging" title (docs item 3) */
3737
docsNativeDebugging: 'Native Debugging',
3838
/** @description "Native Debugging" item detail */
@@ -124,7 +124,7 @@ export class RNWelcomeImpl extends UI.Widget.VBox implements
124124
import.meta.url,
125125
).toString();
126126
const docsImage2Url = new URL(
127-
'../../Images/react_native/learn-react-devtools.jpg',
127+
'../../Images/react_native/learn-react-native-devtools.jpg',
128128
import.meta.url,
129129
).toString();
130130
const docsImage3Url = new URL(
@@ -176,15 +176,14 @@ export class RNWelcomeImpl extends UI.Widget.VBox implements
176176
<p>${i18nString(UIStrings.docsDebuggingBasicsDetail)}</p>
177177
</div>
178178
</button>
179-
<!-- TODO(huntie): Replace this item when React Native DevTools docs are complete -->
180-
<button class="rn-welcome-docsfeed-item" type="button" role="link" @click=${this.#handleLinkPress.bind(this, 'https:\/\/reactnative.dev/docs/debugging/react-devtools')} title=${i18nString(UIStrings.docsReactDevTools)}>
179+
<button class="rn-welcome-docsfeed-item" type="button" role="link" @click=${this.#handleLinkPress.bind(this, 'https:\/\/reactnative.dev/docs/react-devtools')} title=${i18nString(UIStrings.docsReactNativeDevTools)}>
181180
<div class="rn-welcome-image" style="background-image: url('${docsImage2Url}')"></div>
182181
<div>
183-
<p class="devtools-link">${i18nString(UIStrings.docsReactDevTools)}</p>
182+
<p class="devtools-link">${i18nString(UIStrings.docsReactNativeDevTools)}</p>
184183
<p>${i18nString(UIStrings.docsReactDevToolsDetail)}</p>
185184
</div>
186185
</button>
187-
<button class="rn-welcome-docsfeed-item" type="button" role="link" @click=${this.#handleLinkPress.bind(this, 'https:\/\/reactnative.dev/docs/debugging/debugging-native-code')} title=${i18nString(UIStrings.docsNativeDebugging)}>
186+
<button class="rn-welcome-docsfeed-item" type="button" role="link" @click=${this.#handleLinkPress.bind(this, 'https:\/\/reactnative.dev/docs/debugging-native-code')} title=${i18nString(UIStrings.docsNativeDebugging)}>
188187
<div class="rn-welcome-image" style="background-image: url('${docsImage3Url}')"></div>
189188
<div>
190189
<p class="devtools-link">${i18nString(UIStrings.docsNativeDebugging)}</p>

0 commit comments

Comments
 (0)