Consistently apply filters to viewport data grid nodes

Bug: 411285104
Change-Id: Icf309edf064a05a650b5d45754b58dfb7485347e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6468177
Reviewed-by: Simon Zünd <[email protected]>
Commit-Queue: Danil Somsikov <[email protected]>
Commit-Queue: Simon Zünd <[email protected]>
Auto-Submit: Danil Somsikov <[email protected]>

Author: danilsomsikov

front_end/ui/legacy/components/data_grid/ViewportDataGrid.ts

@@ -52,7 +52,7 @@ export class ViewportDataGrid<T> extends Common.ObjectWrapper.eventMixin<EventTy
     this.isStriped = striped;
     let startsWithOdd = true;
     if (this.visibleNodes.length) {
-      const allChildren = (this.rootNode() as ViewportDataGridNode<T>).flatChildren();
+      const allChildren = this.filteredNodes();
       startsWithOdd = Boolean(allChildren.indexOf(this.visibleNodes[0]));
     }
     this.updateStripesClass(startsWithOdd);
@@ -168,8 +168,7 @@ export class ViewportDataGrid<T> extends Common.ObjectWrapper.eventMixin<EventTy
     visibleNodes: Array<ViewportDataGridNode<T>>,
     offset: number,
   } {
-    const nodes =
-        (this.rootNode() as ViewportDataGridNode<T>).flatChildren().filter(this.testNodeWithFilters.bind(this));
+    const nodes = this.filteredNodes();
 
     if (this.inline) {
       return {topPadding: 0, bottomPadding: 0, contentHeight: 0, visibleNodes: nodes, offset: 0};
@@ -210,14 +209,11 @@ export class ViewportDataGrid<T> extends Common.ObjectWrapper.eventMixin<EventTy
   }
 
   override getNumberOfRows(): number {
-    return (this.rootNode() as ViewportDataGridNode<T>)
-        .flatChildren()
-        .filter(this.testNodeWithFilters.bind(this))
-        .length;
+    return this.filteredNodes().length;
   }
 
   private contentHeight(): number {
-    const nodes = (this.rootNode() as ViewportDataGridNode<T>).flatChildren();
+    const nodes = this.filteredNodes();
     let result = 0;
     for (let i = 0, size = nodes.length; i < size; ++i) {
       result += nodes[i].nodeSelfHeight();
@@ -260,7 +256,7 @@ export class ViewportDataGrid<T> extends Common.ObjectWrapper.eventMixin<EventTy
     let offset = viewportState.offset;
 
     if (visibleNodes.length) {
-      const nodes = (this.rootNode() as ViewportDataGridNode<T>).flatChildren();
+      const nodes = this.filteredNodes();
       const index = nodes.indexOf(visibleNodes[0]);
       this.updateStripesClass(Boolean(index % 2));
       if (this.keepScrollingToBottom && index !== -1 && Boolean(index % 2) !== this.firstVisibleIsStriped) {
@@ -297,7 +293,7 @@ export class ViewportDataGrid<T> extends Common.ObjectWrapper.eventMixin<EventTy
   }
 
   revealViewportNode(node: ViewportDataGridNode<T>): void {
-    const nodes = (this.rootNode() as ViewportDataGridNode<T>).flatChildren();
+    const nodes = this.filteredNodes();
     const index = nodes.indexOf(node);
     if (index === -1) {
       return;
@@ -317,6 +313,10 @@ export class ViewportDataGrid<T> extends Common.ObjectWrapper.eventMixin<EventTy
     }
     this.scrollContainer.scrollTop = scrollTop;
   }
+
+  private filteredNodes(): Array<ViewportDataGridNode<T>> {
+    return (this.rootNode() as ViewportDataGridNode<T>).flatChildren().filter(this.testNodeWithFilters.bind(this));
+  }
 }
 
 export const enum Events {