Skip to content

Commit f4188de

Browse files
authored
chore: remove node version pinning from CI (#11866)
1 parent 2f135d3 commit f4188de

File tree

5 files changed

+10
-7
lines changed

5 files changed

+10
-7
lines changed

.circleci/config.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,5 @@ workflows:
7070
partial: true
7171
matrix:
7272
parameters:
73-
# https://github.com/nodejs/node/issues/40030
74-
node-version: ['10', '12', '15', '16.8']
73+
node-version: ['10', '12', '15', '16']
7574
- test-jest-jasmine

.github/workflows/nodejs.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,8 +69,7 @@ jobs:
6969
strategy:
7070
fail-fast: false
7171
matrix:
72-
# https://github.com/nodejs/node/issues/40030
73-
node-version: [10.x, 12.x, 14.x, 15.x, 16.8]
72+
node-version: [10.x, 12.x, 14.x, 15.x, 16.x]
7473
os: [ubuntu-latest, macOS-latest, windows-latest]
7574
runs-on: ${{ matrix.os }}
7675
needs: prepare-yarn-cache

packages/jest-config/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@
5151
"@types/is-ci": "^3.0.0",
5252
"@types/micromatch": "^4.0.1",
5353
"jest-snapshot-serializer-raw": "^1.1.0",
54+
"semver": "^7.3.5",
5455
"strip-ansi": "^6.0.0",
5556
"ts-node": "^9.0.0",
5657
"typescript": "^4.0.3"

packages/jest-config/src/__tests__/normalize.test.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
import {createHash} from 'crypto';
1010
import path from 'path';
1111
import {wrap} from 'jest-snapshot-serializer-raw';
12+
import semver = require('semver');
1213
import stripAnsi from 'strip-ansi';
1314
import type {Config} from '@jest/types';
1415
import {escapeStrForRegex} from 'jest-regex-util';
@@ -1130,6 +1131,10 @@ describe('preset', () => {
11301131
{virtual: true},
11311132
);
11321133

1134+
const errorMessage = semver.satisfies(process.versions.node, '>=16.9.1')
1135+
? "TypeError: Cannot read properties of undefined (reading 'call')"
1136+
: /TypeError: Cannot read property 'call' of undefined[\s\S]* at /;
1137+
11331138
await expect(
11341139
normalize(
11351140
{
@@ -1138,9 +1143,7 @@ describe('preset', () => {
11381143
},
11391144
{} as Config.Argv,
11401145
),
1141-
).rejects.toThrowError(
1142-
/TypeError: Cannot read property 'call' of undefined[\s\S]* at /,
1143-
);
1146+
).rejects.toThrowError(errorMessage);
11441147
});
11451148

11461149
test('works with "react-native"', async () => {

yarn.lock

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12681,6 +12681,7 @@ fsevents@^1.2.7:
1268112681
jest-validate: ^27.2.0
1268212682
micromatch: ^4.0.4
1268312683
pretty-format: ^27.2.0
12684+
semver: ^7.3.5
1268412685
strip-ansi: ^6.0.0
1268512686
ts-node: ^9.0.0
1268612687
typescript: ^4.0.3

0 commit comments

Comments
 (0)