Skip to content

one-line waiting for app start #3411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 5, 2017
Merged

one-line waiting for app start #3411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
416b5c7
one-line waiting for app start
xjlim Nov 5, 2017
cc95923
remove fixed todo
xjlim Nov 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,6 @@ platform:
- x64

install:
# TODO: Remove after https://github.com/appveyor/ci/issues/1426 is fixed
- set PATH=C:\Program Files\Git\mingw64\bin;%PATH%
- ps: Install-Product node $env:nodejs_version $env:platform

build: off
Expand All @@ -41,4 +39,4 @@ skip_commits:
test_script:
- node --version
- npm --version
- sh tasks/e2e-%test_suite%.sh
- bash tasks/e2e-%test_suite%.sh
18 changes: 2 additions & 16 deletions tasks/e2e-kitchensink.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,14 +218,7 @@ PORT=3001 \
REACT_APP_SHELL_ENV_MESSAGE=fromtheshell \
NODE_PATH=src \
nohup npm start &>$tmp_server_log &
while true
do
if grep -q 'You can now view' $tmp_server_log; then
break
else
sleep 1
fi
done
grep -q 'You can now view' <(tail -f $tmp_server_log)
E2E_URL="http://localhost:3001" \
REACT_APP_SHELL_ENV_MESSAGE=fromtheshell \
CI=true NODE_PATH=src \
Expand Down Expand Up @@ -287,14 +280,7 @@ PORT=3002 \
REACT_APP_SHELL_ENV_MESSAGE=fromtheshell \
NODE_PATH=src \
nohup npm start &>$tmp_server_log &
while true
do
if grep -q 'You can now view' $tmp_server_log; then
break
else
sleep 1
fi
done
grep -q 'You can now view' <(tail -f $tmp_server_log)
E2E_URL="http://localhost:3002" \
REACT_APP_SHELL_ENV_MESSAGE=fromtheshell \
CI=true NODE_PATH=src \
Expand Down