This repository was archived by the owner on May 7, 2021. It is now read-only.
Feature to allow or disallow saving empty field is added #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The value of nodeValue is coming null sometime - To reproduce the bug start editing, blur the field and focus again on the field and see th error on console.
|
Do you have a link to the task or user-story? |
|
The issue is in planner - openshiftio/openshift.io#2538 |
|
Can you add a test for the new feature? |
vikram-raj
reviewed
Jun 12, 2018
| (click)="saveClick()" | ||
| class="fl btn btn-primary pull-right action-btn btn-save" | ||
| [disabled]="saving" | ||
| [disabled]="saving || (!allowEmptySave && fieldEmpty)" |
There was a problem hiding this comment.
Same conditions should check for the disabled class as well in line no. 58.
There was a problem hiding this comment.
We don't actually need a class. It's a button so disabled property should work by itself
|
@joshuawilson added tests for the new feature. |
vikram-raj
approved these changes
Jun 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.