Skip to content

Conversation

@9547
Copy link
Contributor

@9547 9547 commented Jun 3, 2024

deriveLogFields is a testing-only function and can be replaced with another one. This pull request deprecates this "unused" function for clean up.

@rjl493456442 rjl493456442 changed the title core/rawdb: move deriveLogFields into the test file core/rawdb: remove unused deriveLogFields Jun 4, 2024
@rjl493456442 rjl493456442 added this to the 1.14.4 milestone Jun 4, 2024
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nit, otherwise LGTM

@karalabe karalabe modified the milestones: 1.14.4, 1.14.5 Jun 4, 2024
@rjl493456442 rjl493456442 merged commit d09ddac into ethereum:master Jun 5, 2024
@9547 9547 deleted the derive-log branch June 7, 2024 01:13
jorgemmsilva pushed a commit to iotaledger/go-ethereum that referenced this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants