Skip to content

Conversation

@0xmountaintop
Copy link
Contributor

No description provided.

@0xmountaintop 0xmountaintop changed the title i8ntool: fix a typo cmd: fix a typo May 30, 2024
}
if env.ParentBaseFee == nil || env.Number == 0 {
return NewError(ErrorConfig, errors.New("EIP-1559 config but missing 'currentBaseFee' in env section"))
return NewError(ErrorConfig, errors.New("EIP-1559 config but missing 'ParentBaseFee' in env section"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use parentBaseFee, that's the JSON name

Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karalabe karalabe added this to the 1.14.4 milestone Jun 3, 2024
@karalabe karalabe merged commit 50405e2 into ethereum:master Jun 3, 2024
@0xmountaintop 0xmountaintop deleted the patch-2 branch June 4, 2024 07:55
jorgemmsilva pushed a commit to iotaledger/go-ethereum that referenced this pull request Jun 17, 2024
* i8ntool: fix a typo

* cmd/evm/internal/t8ntool: fix typo typo

---------

Co-authored-by: Péter Szilágyi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants