-
Notifications
You must be signed in to change notification settings - Fork 7.7k
BLE upgrades #7867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLE upgrades #7867
Conversation
|
@PilnyTomas - There are commits from 2022 in this PR. Is it right? |
To be honest, I don't know how they got there, but considering that they are mostly just merges of master it shouldn't be a problem. The only change was adding the vector #include, but as is not needed I have removed it in one of the following commits. |
lucasssvaz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested all examples. Everything works as expected. Just some indentation problems, mainly where std::strings were replaced by Strings
Co-authored-by: Lucas Saavedra Vaz <[email protected]>
|
Related to the BLE refactoring: #7702 |
|
Closed in favor of #8724 |

General:
BREAKING CHANGE! Changed API return and parameter type from
std::tringto Arduino styleString.Renamed library name from
ESP32 BLE Arduinoto simpleBLE.Created a new function
getFramewhich returns complete data forBLEAdvertisementData::addData().Renamed example files - removed prefix
BLE_-BLE5_is left unchanged.Beacon_Scannerexample updated to reflect changes in API - shortened by 28 lines on TLM and URL part.Changed UUID data type from
uint16_ttoBLEUUIDclassEddysstone URL:
Created a new constructor which takes as an argument a
BLEAdvertisedDeviceobject and initializes URL data from the payload.Created a new function
BLEEddystoneURL::setSmartURLwhich encodes the full URL structure.Static frame data no longer needs to be written by the user - they are initialized by the constructor.
Function
BLEEddystoneURL::setPowernow acceptsesp_power_level_t.Updated
EddystoneURL_Beaconexample to reflect changes in API - shortened by 83 lines.Added comments with explanations to functions
setDataandsetURL.Tests:
EddystoneURL_Beaconwith the following URLs and read them inBeacon_Scannerexample and using an Android app nRF Connect for Mobile.Eddystone TLM:
Created a new constructor which takes as an argument a
BLEAdvertisedDeviceobject and initializes TLM data from the payload.Added comments with explanations to functions
setDataandsetVoltTODO: test all examples if they are properly working - changes related to the String might have broken something!
Related task: #7841