-
Notifications
You must be signed in to change notification settings - Fork 543
Open
Labels
area/egctlarea/providerarea/standaloneIssues related to the standalone modeIssues related to the standalone modekind/refactorstale
Milestone
Description
Description:
For now, the kubernetesYAMLToResources
function in egctl x translate
only able to process one GatewayClass, for multiple GC case, the translation will fail.
gateway/internal/cmd/egctl/translate.go
Line 628 in c0068a0
func kubernetesYAMLToResources(str string, addMissingResources bool) (*gatewayapi.Resources, error) { |
IMO, above function should return something like:
type LoadResources struct {
Resources
GatewayClasses []*gwv1.GatewayClass
EnvoyProxies []*egv1a1.EnvoyProxy
}
- The GC and EP should be stored in list instead of variable
- Above function should be placed in gatewayapi layer (This will be super helpful for file-provider in standalone mode to reuse this logic to load all kinds of resources from file)
Any thoughts on this? cc @envoyproxy/gateway-maintainers
[optional Relevant Links:]
Any extra documentation required to understand the issue.
Metadata
Metadata
Assignees
Labels
area/egctlarea/providerarea/standaloneIssues related to the standalone modeIssues related to the standalone modekind/refactorstale