Merge pull request #991 from ericmj/exunit_exit

Use monitors in ExUnit and document callbacks

Author: José Valim

lib/ex_unit/lib/ex_unit/callbacks.ex

@@ -79,6 +79,9 @@ defmodule ExUnit.Callbacks do
       compile_callbacks(env, :exunit_teardown_all) ]
   end
 
+  @doc """
+  Called before the start of each test.
+  """
   defmacro setup(var // quote(do: _), block) do
     quote do
       name = :"__exunit_setup_#{length(@exunit_setup)}"
@@ -87,6 +90,10 @@ defmodule ExUnit.Callbacks do
     end
   end
 
+  @doc """
+  Called after the finish of each test. Note that, if the test crasches with an exit
+  message `teardown` will not be run.
+  """
   defmacro teardown(var // quote(do: _), block) do
     quote do
       name = :"__exunit_teardown_#{length(@exunit_teardown)}"
@@ -95,6 +102,9 @@ defmodule ExUnit.Callbacks do
     end
   end
 
+  @doc """
+  Called before the start of a case.
+  """
   defmacro setup_all(var // quote(do: _), block) do
     quote do
       name = :"__exunit_setup_all_#{length(@exunit_setup_all)}"
@@ -103,6 +113,9 @@ defmodule ExUnit.Callbacks do
     end
   end
 
+  @doc """
+  Called after the finish of each case.
+  """
   defmacro teardown_all(var // quote(do: _), block) do
     quote do
       name = :"__exunit_teardown_all_#{length(@exunit_teardown_all)}"

lib/ex_unit/lib/ex_unit/runner.ex

@@ -89,9 +89,8 @@ defmodule ExUnit.Runner do
     config.formatter.test_started(config.formatter_id, test)
 
     # Run test in a new process so that we can trap exits for a single test
-    Process.flag(:trap_exit, true)
     self_pid = self
-    test_pid = spawn_link fn ->
+    { test_pid, test_ref } = Process.spawn_monitor fn ->
       test = try do
         context = test_case.__exunit__(:setup, Keyword.put(context, :test, test))
 
@@ -122,7 +121,7 @@ defmodule ExUnit.Runner do
     receive do
       { ^test_pid, :test_finished, test } ->
         pid <- { test_pid, :test_finished, test }
-      { :EXIT, ^test_pid, { error, stacktrace } } ->
+      { :DOWN, ^test_ref, :process, ^test_pid, { error, stacktrace } } ->
         test = test.failure { :EXIT, error, filter_stacktrace(stacktrace) }
         pid <- { test_pid, :test_finished, test }
     end