Focus current tab (#638)

* Focus terminal tab when notification is clicked.

* add meson.build

* Update src/Application.vala

Co-authored-by: Gustavo Marques <[email protected]>

* Rewrite for TerminalView; Use hack to raise window

---------

Co-authored-by: Jeremy Wootten <[email protected]>
Co-authored-by: Jeremy Wootten <[email protected]>
Co-authored-by: Gustavo Marques <[email protected]>

Author: 4 people

src/Application.vala

@@ -31,6 +31,35 @@ public class Terminal.Application : Gtk.Application {
         Intl.bind_textdomain_codeset (Config.GETTEXT_PACKAGE, "UTF-8");
         Intl.textdomain (Config.GETTEXT_PACKAGE);
 
+        var act = new SimpleAction ("process-finished", VariantType.STRING);
+        add_action (act);
+        act.activate.connect ((v) => {
+            MainWindow window_to_present = (MainWindow)active_window;
+            size_t len;
+            var tid = v.get_string (out len);
+            foreach (var window in (List<MainWindow>) get_windows ()) {
+                var terminal = window.get_terminal (tid);
+                if (terminal != null) {
+                    window.set_active_terminal_tab (terminal.tab);
+                    window_to_present = window;
+                    break;
+                }
+            }
+
+            // This is a hack to avoid using Gdk-Xii dependency.  Using present_with_time ()
+            // with the current event time does not work either on X11 or Wayland perhaps
+            // because the triggering event did not occur on the Terminal window?
+            // Using set_keep_above () at least works on X11 but not on Wayland
+            //TODO It may well be possible to use present () on Gtk4 so this needs revisiting
+            window_to_present.set_keep_above (true);
+            window_to_present.present ();
+            window_to_present.grab_focus ();
+            Idle.add (() => {
+                window_to_present.set_keep_above (false);
+                return Source.REMOVE;
+            });
+        });
+
         add_main_option ("version", 'v', 0, OptionArg.NONE, _("Show version"), null);
         // -n flag forces a new window
         add_main_option ("new-window", 'n', 0, OptionArg.NONE, _("Open a new terminal window"), null);
@@ -171,7 +200,8 @@ public class Terminal.Application : Gtk.Application {
                 var notification = new Notification (process_string);
                 notification.set_body (process);
                 notification.set_icon (process_icon);
-                send_notification (null, notification);
+                notification.set_default_action_and_target_value ("app.process-finished", new Variant.string (id));
+                send_notification ("process-finished-%s".printf (id), notification);
             }
         });
 

src/MainWindow.vala

@@ -1117,6 +1117,10 @@ namespace Terminal {
             return null;
         }
 
+        public void set_active_terminal_tab (Hdy.TabPage tab) {
+            notebook.tab_view.selected_page = tab;
+        }
+
         /** Compare every tab label with every other and resolve ambiguities **/
         private void check_for_tabs_with_same_name () requires (current_terminal != null) {
             int i = 0;