fix: bind mouse events in web worker #448
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Web workers do support addEventListener ( aka. EventTarget ) and
requestAnimationFrame, but worker do not have the global object window.Instead of window, we should use a better option to get the global object. globalThis is the best option indeed, but we can't use it due to its poor compatibility. Browser and worker both support self, and it has very good browser compatibility. Using
selfcan be a better option than using window.This PR generally enables OffscreenCanvas support of zrender, which may greatly improve the performance of echarts.
Ref: apache/echarts#9232