Changes after code review

Author: asimgunes

esbuild.js

@@ -3,18 +3,18 @@ const esbuild = require('esbuild');
 const path = require('node:path');
 const os = require('node:os');
 const { sassPlugin } = require('esbuild-sass-plugin');
-const { dtsPlugin } = require('esbuild-plugin-d.ts');
 
 /** @typedef {import('esbuild').BuildOptions} BuildOptions */
 
 const args = process.argv.slice(2);
 const CLIWatch = args.includes('--watch');
+const NoMinify = args.includes('--no-minify');
 
 /** @type {BuildOptions} */
 const commonConfig = {
     bundle: true,
     target: ['es2020'],
-    minify: true,
+    minify: !NoMinify,
     sourcemap: true,
 };
 
@@ -27,23 +27,6 @@ const debugAdapterRoot = path.join(
 );
 /** @type {BuildOptions[]} */
 const configurations = [
-    {
-        entryPoints: [path.join(sourceRoot, 'extension.ts')],
-        outfile: path.join(__dirname, 'dist', 'extension.cjs.js'),
-        external: ['vscode'],
-        format: 'cjs',
-        platform: 'node',
-        ...commonConfig,
-    },
-    {
-        entryPoints: [path.join(sourceRoot, 'extension.ts')],
-        outfile: path.join(__dirname, 'dist', 'extension.esm.js'),
-        external: ['vscode'],
-        plugins: [dtsPlugin()],
-        format: 'esm',
-        platform: 'node',
-        ...commonConfig,
-    },
     {
         entryPoints: [path.join(sourceRoot, 'memory', 'client', 'index.tsx')],
         outfile: path.join(__dirname, 'dist', 'MemoryBrowser.js'),

package.json

@@ -14,8 +14,7 @@
     "url": "https://github.com/eclipse-cdt-cloud/cdt-gdb-vscode/issues"
   },
   "homepage": "https://github.com/eclipse-cdt-cloud/cdt-gdb-vscode#readme",
-  "main": "./dist/extension.cjs.js",
-  "module": "./dist/extension.esm.js",
+  "main": "./dist/extension",
   "types": "./dist/extension.d.ts",
   "engines": {
     "vscode": "^1.78.0"
@@ -724,6 +723,8 @@
     }
   },
   "scripts": {
+    "build:tsc": "tsc -b",
+    "watch:tsc": "tsc -b -w",
     "build:esbuild": "node esbuild.js",
     "watch:esbuild": "node esbuild.js --watch",
     "build": "run-s build:*",
@@ -755,7 +756,6 @@
     "@vscode/vsce": "^2.18.0",
     "chai": "^4.3.7",
     "esbuild": "^0.19.2",
-    "esbuild-plugin-d.ts": "^1.1.0",
     "esbuild-sass-plugin": "^2.13.0",
     "eslint": "^8.35.0",
     "event-stream": "^4.0.1",
@@ -776,6 +776,7 @@
     "dist/**/*.css",
     "dist/**/*.css.map",
     "dist/**/*.d.ts",
+    "dist/**/*.d.ts.map",
     "src/**/*.ts",
     "src/**/*.tsx",
     "src/**/*.scss"

src/memory/client/tsconfig.json

@@ -2,7 +2,7 @@
   "extends": "../../../tsconfig.json",
   "compilerOptions": {
     "composite": true,
-    "outDir": "../../../out/memory",
+    "outDir": "../../../dist/memory",
     "rootDir": "../",
     "esModuleInterop": true
   },

tsconfig.json

@@ -8,6 +8,8 @@
     "lib": ["es2015", "dom"],
     "jsx": "react",
     "strict": true,
+    "declaration": true,
+    "declarationMap": true,
     "noImplicitAny": true,
     "noImplicitReturns": true,
     "noUnusedLocals": true,
@@ -17,5 +19,5 @@
     "preserveWatchOutput": true
   },
   "references": [{ "path": "src/memory/client/tsconfig.json" }],
-  "exclude": ["**/client/*"]
+  "exclude": ["**/client/*", "**/dist/*"]
 }