Fix InsertRelation on attached database

Author: evertlammerts

src/duckdb_py/pyrelation.cpp

@@ -23,6 +23,8 @@
 #include "duckdb/common/arrow/physical_arrow_collector.hpp"
 #include "duckdb_python/arrow/arrow_export_utils.hpp"
 
+#include <duckdb/main/relation/table_relation.hpp>
+
 namespace duckdb {
 
 DuckDBPyRelation::DuckDBPyRelation(shared_ptr<Relation> rel_p) : rel(std::move(rel_p)) {
@@ -1511,7 +1513,7 @@ DuckDBPyRelation &DuckDBPyRelation::Execute() {
 void DuckDBPyRelation::InsertInto(const string &table) {
 	AssertRelation();
 	auto parsed_info = QualifiedName::Parse(table);
-	auto insert = rel->InsertRel(parsed_info.schema, parsed_info.name);
+	auto insert = rel->InsertRel(parsed_info.catalog, parsed_info.schema, parsed_info.name);
 	PyExecuteRelation(insert);
 }
 
@@ -1565,14 +1567,24 @@ void DuckDBPyRelation::Update(const py::object &set_p, const py::object &where)
 
 void DuckDBPyRelation::Insert(const py::object &params) {
 	AssertRelation();
-	if (!IsAcceptedInsertRelationType(*this->rel)) {
+	if (this->rel->type != RelationType::TABLE_RELATION) {
 		throw InvalidInputException("'DuckDBPyRelation.insert' can only be used on a table relation");
 	}
 	vector<vector<Value>> values {DuckDBPyConnection::TransformPythonParamList(params)};
 
 	D_ASSERT(py::gil_check());
 	py::gil_scoped_release release;
-	rel->Insert(values);
+	// Grab table info
+	auto table_relation = static_cast<TableRelation *>(this->rel.get());
+	auto catalog = table_relation->description->database;
+	auto schema = table_relation->description->schema;
+	auto table = table_relation->description->table;
+	// Create a value relation
+	vector<string> column_names;
+	auto value_rel =
+	    make_shared_ptr<ValueRelation>(this->rel->context->GetContext(), values, std::move(column_names), "values");
+	// Now insert
+	value_rel->Insert(catalog, schema, table);
 }
 
 void DuckDBPyRelation::Create(const string &table) {