apply feedback from Yanni and update copilot instructions to account for formatting

Author: baronfel

.github/copilot-instructions.md

@@ -2,6 +2,9 @@ Coding Style and Changes:
 - Code should match the style of the file it's in.
 - Changes should be minimal to resolve a problem in a clean way.
 - User-visible changes to behavior should be considered carefully before committing. They should always be flagged.
+- When generating code, run `dotnet format` to ensure uniform formatting.
+- Prefer using file-based namespaces for new code.
+- Do not allow unused `using` directives to be committed.
 
 Testing:
 - Large changes should always include test changes.

src/Tasks/Microsoft.NET.Build.Tasks/PickBestRid.cs

@@ -4,58 +4,54 @@
 using Microsoft.Build.Framework;
 using NuGet.RuntimeModel;
 
-namespace Microsoft.NET.Build.Tasks
+namespace Microsoft.NET.Build.Tasks;
+
+/// <summary>
+/// This task uses the given RID graph in a given SDK to pick the best match from among a set of supported RIDs for the current RID
+/// </summary>
+public sealed class PickBestRid : TaskBase
 {
     /// <summary>
-    /// This task uses the given RID graph in a given SDK to pick the best match from among a set of supported RIDs for the current RID
+    /// The path to the RID graph to read
+    /// </summary>
+    [Required]
+    public string RuntimeGraphPath { get; set; } = "";
+
+    /// <summary>
+    /// The RID to find the best fit for
+    /// </summary>
+    [Required]
+    public string TargetRid { get; set; } = "";
+
+    /// <summary>
+    /// All of the RIDs that are allowed to match against the <see cref="TargetRid"/>
+    /// </summary>
+    [Required]
+    public string[] SupportedRids { get; set; } = Array.Empty<string>();
+
+    /// <summary>
+    /// The RID from among <see cref="SupportedRids"/> that best matches the <see cref="TargetRid"/>, if any.
     /// </summary>
-    public sealed class PickBestRid : TaskBase
+    [Output]
+    public string? MatchingRid { get; set; }
+
+    protected override void ExecuteCore()
     {
-        /// <summary>
-        /// The path to the RID graph to read
-        /// </summary>
-        [Required]
-        public string RuntimeGraphPath { get; set; } = "";
-
-        /// <summary>
-        /// The RID to find the best fit for
-        /// </summary>
-        [Required]
-        public string TargetRid { get; set; } = "";
-
-        /// <summary>
-        /// All of the RIDs that are allowed to match against the Target RID
-        /// </summary>
-        [Required]
-        public string[] SupportedRids { get; set; } = Array.Empty<string>();
-
-        /// <summary>
-        /// The solution to the puzzle
-        /// </summary>
-        [Output]
-        public string? MatchingRid { get; set; }
-
-        /// <summary>
-        /// Finds the best matching RID from the supported RIDs using the runtime graph.
-        /// </summary>
-        protected override void ExecuteCore()
+        if (!File.Exists(RuntimeGraphPath))
+        {
+            Log.LogError(Strings.RuntimeGraphFileDoesNotExist, RuntimeGraphPath);
+            return;
+        }
+
+        RuntimeGraph graph = new RuntimeGraphCache(this).GetRuntimeGraph(RuntimeGraphPath);
+        var bestRidForPlatform = NuGetUtils.GetBestMatchingRid(graph, TargetRid, SupportedRids, out bool wasInGraph);
+
+        if (!wasInGraph || bestRidForPlatform == null)
         {
-            if (!File.Exists(RuntimeGraphPath))
-            {
-                Log.LogError(Strings.RuntimeGraphFileDoesNotExist, RuntimeGraphPath);
-                return;
-            }
-
-            RuntimeGraph graph = new RuntimeGraphCache(this).GetRuntimeGraph(RuntimeGraphPath);
-            string bestRidForPlatform = NuGetUtils.GetBestMatchingRid(graph, TargetRid, SupportedRids, out bool wasInGraph);
-
-            if (!wasInGraph || bestRidForPlatform == null)
-            {
-                Log.LogError(Strings.UnableToFindMatchingRid, TargetRid, string.Join(",", SupportedRids), RuntimeGraphPath);
-                return;
-            }
-
-            MatchingRid = bestRidForPlatform;
+            Log.LogError(Strings.UnableToFindMatchingRid, TargetRid, string.Join(",", SupportedRids), RuntimeGraphPath);
+            return;
         }
+
+        MatchingRid = bestRidForPlatform;
     }
-}
+}