Use separate cache keys for registry and realm #286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baronfel
changed the title
rainersigwald
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we lookup any stored credentials through the docker auth mechanism, we should use the registry as the key. This is the value that users are expected to interact with when 'priming' the config file. Our short-lived token cache can still use the
realmhere - the short-lived token cache has a subsequent step that reuses the token generated for therealmfor calls to the `registry.This works very well and actually ended up being something that fixed our GitHub test workflow (ignore the Google Cloud failure here): https://github.com/baronfel/sdk-container-demo/actions/runs/3887048885
Closes #284