Skip to content

Commit d40974b

Browse files
author
Oren Novotny
committed
Add reference based on UseWpf or UseWindowsForms
1 parent d7a3a38 commit d40974b

File tree

4 files changed

+34
-1
lines changed

4 files changed

+34
-1
lines changed

Rx.NET/Source/Directory.build.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
<DebugType>embedded</DebugType>
1313
<SignAssembly>true</SignAssembly>
1414
<AssemblyOriginatorKeyFile>$(MSBuildThisFileDirectory)ReactiveX.snk</AssemblyOriginatorKeyFile>
15-
<NoWarn>$(NoWarn);1701;1702;CS1591</NoWarn>
15+
<NoWarn>$(NoWarn);1701;1702;CS1591;NU5105</NoWarn>
1616
<DefaultLanguage>en-US</DefaultLanguage>
1717
<IncludeSymbols>false</IncludeSymbols>
1818
<IsTestProject>$(MSBuildProjectName.Contains('Tests'))</IsTestProject>

Rx.NET/Source/src/System.Reactive/System.Reactive.csproj

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
<PropertyGroup Condition="'$(TargetFramework)' == 'netcoreapp3.0'">
1010
<UseWPF>true</UseWPF>
1111
<UseWindowsForms>true</UseWindowsForms>
12+
<IncludeBuildOutput>false</IncludeBuildOutput>
1213
</PropertyGroup>
1314

1415

@@ -63,5 +64,27 @@
6364
<None Update="Linq\Observable\Zip.Generated.tt" Generator="TextTemplatingFileGenerator" LastGenOutput="Zip.Generated.cs" />
6465
<Compile Update="Linq\Observable\Zip.Generated.cs" DesignTime="True" AutoGen="True" DependentUpon="Zip.Generated.tt" />
6566
</ItemGroup>
67+
68+
<PropertyGroup>
69+
<TargetsForTfmSpecificBuildOutput>$(TargetsForTfmSpecificBuildOutput);RemoveNetCoreApp3FromNuGet</TargetsForTfmSpecificBuildOutput>
70+
</PropertyGroup>
71+
72+
<!-- We remove the output from the nuget so it doesn't wind up in the \lib folder -->
73+
<Target Name="RemoveNetCoreApp3FromNuGet" DependsOnTargets="BuiltProjectOutputGroup;DocumentationProjectOutputGroup" Condition="'$(TargetFramework)' == 'netcoreapp3.0'">
74+
75+
<ItemGroup>
76+
<BuiltProjectOutputGroupOutput Remove="@(BuiltProjectOutputGroupOutput)" />
77+
<DocumentationProjectOutputGroupOutput Remove="@(DocumentationProjectOutputGroupOutput)" />
78+
</ItemGroup>
79+
80+
</Target>
81+
82+
83+
<ItemGroup>
84+
<None Include="bin\$(Configuration)\netcoreapp3.0\*.xml" PackagePath="buildTransitive\netcoreapp3.0" Pack="true" />
85+
<None Include="bin\$(Configuration)\netcoreapp3.0\*.dll" PackagePath="buildTransitive\netcoreapp3.0" Pack="true" />
86+
<None Include="build\_._" PackagePath="lib\netcoreapp3.0" Pack="true" />
87+
<None Include="build\System.Reactive.targets" PackagePath="buildTransitive\netcoreapp3.0" Pack="true" />
88+
</ItemGroup>
6689

6790
</Project>
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
<Project>
2+
<PropertyGroup>
3+
<UseWindowsRxVersion Condition="'$(UseWpf)' == 'true' OR '$(UseWindowsForms)' == 'true'" >true</UseWindowsRxVersion>
4+
<UseWindowsRxVersion Condition="'$(UseWindowsVersion)' == '' " >false</UseWindowsRxVersion>
5+
</PropertyGroup>
6+
<ItemGroup>
7+
<Reference Condition="'$(UseWindowsRxVersion)' == 'true' " Include="$(MSBuildThisFileDirectory)System.Reactive.dll" />
8+
<Reference Condition="'$(UseWindowsRxVersion)' != 'true' " Include="$(MSBuildThisFileDirectory)..\..\lib\netstandard2.0\System.Reactive.dll" />
9+
</ItemGroup>
10+
</Project>

Rx.NET/Source/src/System.Reactive/build/_._

Whitespace-only changes.

0 commit comments

Comments
 (0)