Migrate a set of fsharpqa tests to new test suite (overload resolution error messages) (#6654)

* migrate (as a separate copy) fsharpqa tests that are going to be impacted by #6596

the baseline files are empty on purpose, expecting CI failure reporting those tests, I intend to update the baseline and clean up the comments / xml tags from fsharpqa syntax in later commit, and then remove those specific tests altogether from fsharpqa if this is OK with the maintainers.

* update the .bsl files

* remove comments that are handled by baseline files, update baseline files

* remove the migrated tests from fsharpqa tests

* need to be more careful when migrating those

* testing if running the test with .fs instead of .fsx makes them work on .netcore

* exclude migrated fsharpqa from dotnet core run

Author: smoothdeveloper

tests/fsharp/conformance/expressions/syntacticsugar/E_Slices01.bsl

@@ -0,0 +1,14 @@
+
+E_Slices01.fsx(22,9,22,19): typecheck error FS0041: A unique overload for method 'GetSlice' could not be determined based on type information prior to this program point. A type annotation may be needed. Candidates: member Foo.GetSlice : x:int * y1:int option * y2:float option -> unit, member Foo.GetSlice : x:int * y1:int option * y2:int option -> unit
+
+E_Slices01.fsx(23,9,23,17): typecheck error FS0041: A unique overload for method 'GetSlice' could not be determined based on type information prior to this program point. A type annotation may be needed. Candidates: member Foo.GetSlice : x:int * y1:int option * y2:float option -> unit, member Foo.GetSlice : x:int * y1:int option * y2:int option -> unit
+
+E_Slices01.fsx(24,9,24,19): typecheck error FS0041: A unique overload for method 'GetSlice' could not be determined based on type information prior to this program point. A type annotation may be needed. Candidates: member Foo.GetSlice : x1:float option * x2:int option * y:int -> unit, member Foo.GetSlice : x1:int option * x2:int option * y:int -> unit
+
+E_Slices01.fsx(25,9,25,17): typecheck error FS0041: A unique overload for method 'GetSlice' could not be determined based on type information prior to this program point. A type annotation may be needed. Candidates: member Foo.GetSlice : x1:float option * x2:int option * y:int -> unit, member Foo.GetSlice : x1:int option * x2:int option * y:int -> unit
+
+E_Slices01.fsx(26,9,26,17): typecheck error FS0039: The field, constructor or member 'Item' is not defined.
+
+E_Slices01.fsx(27,9,27,26): typecheck error FS0503: A member or object constructor 'GetSlice' taking 4 arguments is not accessible from this code location. All accessible versions of method 'GetSlice' take 3 arguments.
+
+E_Slices01.fsx(28,9,28,20): typecheck error FS0503: A member or object constructor 'GetSlice' taking 5 arguments is not accessible from this code location. All accessible versions of method 'GetSlice' take 3 arguments.

tests/fsharpqa/Source/Conformance/Expressions/SyntacticSugar/E_Slices01.fs renamed to tests/fsharp/conformance/expressions/syntacticsugar/E_Slices01.fsx

@@ -0,0 +1,4 @@
+
+E_LeftToRightOverloadResolution01.fsx(7,23,7,51): typecheck error FS0041: A unique overload for method 'WriteLine' could not be determined based on type information prior to this program point. A type annotation may be needed. Candidates: System.Console.WriteLine(buffer: char []) : unit, System.Console.WriteLine(format: string, [<System.ParamArray>] arg: obj []) : unit, System.Console.WriteLine(value: bool) : unit, System.Console.WriteLine(value: char) : unit, System.Console.WriteLine(value: decimal) : unit, System.Console.WriteLine(value: float) : unit, System.Console.WriteLine(value: float32) : unit, System.Console.WriteLine(value: int) : unit, System.Console.WriteLine(value: int64) : unit, System.Console.WriteLine(value: obj) : unit, System.Console.WriteLine(value: string) : unit, System.Console.WriteLine(value: uint32) : unit, System.Console.WriteLine(value: uint64) : unit
+
+E_LeftToRightOverloadResolution01.fsx(9,23,9,51): typecheck error FS0041: A unique overload for method 'WriteLine' could not be determined based on type information prior to this program point. A type annotation may be needed. Candidates: System.Console.WriteLine(buffer: char []) : unit, System.Console.WriteLine(format: string, [<System.ParamArray>] arg: obj []) : unit, System.Console.WriteLine(value: bool) : unit, System.Console.WriteLine(value: char) : unit, System.Console.WriteLine(value: decimal) : unit, System.Console.WriteLine(value: float) : unit, System.Console.WriteLine(value: float32) : unit, System.Console.WriteLine(value: int) : unit, System.Console.WriteLine(value: int64) : unit, System.Console.WriteLine(value: obj) : unit, System.Console.WriteLine(value: string) : unit, System.Console.WriteLine(value: uint32) : unit, System.Console.WriteLine(value: uint64) : unit

tests/fsharp/conformance/inference/E_Clashing_Values_in_AbstractClass01.bsl

@@ -0,0 +1,12 @@
+// #Regression #TypeInference 
+// Regression for FSHARP1.0:5749
+// Better error message for overload resolution to help ease pain associated with mismatch of intellisense information
+
+
+let array = [| "Ted"; "Katie"; |]
+Array.iter (fun it -> System.Console.WriteLine(it))
+
+Array.iter (fun it -> System.Console.WriteLine(it)) array
+
+array |> Array.iter (fun it -> System.Console.WriteLine(it))
+

tests/fsharp/conformance/inference/E_Clashing_Values_in_AbstractClass03.bsl

@@ -0,0 +1,4 @@
+
+E_OneTypeVariable03.fsx(60,34,60,44): typecheck error FS0041: A unique overload for method 'M' could not be determined based on type information prior to this program point. A type annotation may be needed. Candidates: static member C23.M : x:'a * y:'b -> Two, static member C23.M : x:'a * y:int -> Three
+
+E_OneTypeVariable03.fsx(61,34,61,45): typecheck error FS0041: A unique overload for method 'M' could not be determined based on type information prior to this program point. A type annotation may be needed. Candidates: static member C123.M : x:'a * y:'a -> One, static member C123.M : x:'a * y:'b -> Two, static member C123.M : x:'a * y:int -> Three

tests/fsharp/conformance/inference/E_Clashing_Values_in_AbstractClass04.bsl

@@ -0,0 +1,62 @@
+// #Regression #TypeInference 
+// Regression test for FSHARP1.0:4758
+// Type Inference
+// Check Method Disambiguation When User Generic Variable Get Instantiated By Overload Resolution
+
+// These different return types are used to determine which overload got chosen
+type One = | One
+type Two = | Two
+type Three = | Three
+type Four = | Four
+
+// An unsealed type
+type C() = 
+    member x.P = 1
+    
+type C1 =
+    static member M<'a>(x:'a,y:'a) = One
+
+type C2 =
+    static member M<'a,'b>(x:'a,y:'b) = Two
+
+type C3 =    
+    static member M<'a>(x:'a,y:int) = Three
+
+type C4 =    
+    static member M<'a>(x:'a,y:C) = Four
+
+type C12 =
+    static member M<'a>(x:'a,y:'a) = One
+    static member M<'a,'b>(x:'a,y:'b) = Two
+
+type C23 =
+    static member M<'a,'b>(x:'a,y:'b) = Two
+    static member M<'a>(x:'a,y:int) = Three
+
+type C13 =
+    static member M<'a>(x:'a,y:'a) = One
+    static member M<'a>(x:'a,y:int) = Three
+
+type C14 =
+    static member M<'a>(x:'a,y:'a) = One
+    static member M<'a>(x:'a,y:C) = Four
+
+type C24 =
+    static member M<'a,'b>(x:'a,y:'b) = Two
+    static member M<'a>(x:'a,y:C) = Four
+
+type C123 =
+    static member M<'a>(x:'a,y:'a) = One
+    static member M<'a,'b>(x:'a,y:'b) = Two
+    static member M<'a>(x:'a,y:int) = Three
+
+type C1234 =
+    static member M<'a>(x:'a,y:'a) = One
+    static member M<'a,'b>(x:'a,y:'b) = Two
+    static member M<'a>(x:'a,y:int) = Three
+    static member M<'a>(x:'a,y:C) = Four
+
+module M3 =
+    let gB23    (x:'a) (y:int) = C23.M(x,y)           // expect: ambiguity error
+    let gB123   (x:'a) (y:int) = C123.M(x,y)          // expect: ambiguous on 2,3
+

tests/fsharp/conformance/inference/E_LeftToRightOverloadResolution01.bsl

@@ -0,0 +1,4 @@
+
+E_OneTypeVariable03rec.fsx(60,38,60,48): typecheck error FS0041: A unique overload for method 'M' could not be determined based on type information prior to this program point. A type annotation may be needed. Candidates: static member C23.M : x:'a * y:'b -> Two, static member C23.M : x:'a * y:int -> Three
+
+E_OneTypeVariable03rec.fsx(61,38,61,49): typecheck error FS0041: A unique overload for method 'M' could not be determined based on type information prior to this program point. A type annotation may be needed. Candidates: static member C123.M : x:'a * y:'a -> One, static member C123.M : x:'a * y:'b -> Two, static member C123.M : x:'a * y:int -> Three