[rc2] Ignore line endings when comparing strings in MigrationsModelDiffer #36664
+144
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35382
Description
In EF9 we added a warning when applying migrations and the current model doesn't match the model snapshot from the latest migration. However, the migrations might be generated on a machine with a different OS than the machine that compiles the app. This results in a false positive warning if the model contains any multi-line strings.
Customer impact
If the user has configured warnings to throw by default, then this will result in an exception (usually on startup) in the above scenario. The workaround is to suppress this warning.
How found
This was reported by multiple users on EF9
Regression
Yes, from EF8
Testing
Tests added.
Risk
Low, only affects model diffing logic