Skip to content

Commit 0e521aa

Browse files
authored
Merge pull request #36164 from mmitche/use-non-arch-properties
Use non-arch specific properties for shared framework versions
1 parent a5baf8c commit 0e521aa

File tree

5 files changed

+5
-9
lines changed

5 files changed

+5
-9
lines changed

eng/Version.Details.xml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -42,11 +42,7 @@
4242
<Uri>https://github.com/dotnet/dotnet</Uri>
4343
<Sha>0a01b394b186e190a80cb55740c13f6293cf5446</Sha>
4444
</Dependency>
45-
<!--
46-
Win-x64 is used here because we have picked an arbitrary runtime identifier to flow the version of the latest NETCore.App runtime.
47-
All Runtime.$rid packages should have the same version.
48-
-->
49-
<Dependency Name="Microsoft.NETCore.App.Runtime.win-x64" Version="10.0.0-preview.6.25278.103">
45+
<Dependency Name="Microsoft.NETCore.Platforms" Version="10.0.0-preview.6.25278.103">
5046
<Uri>https://github.com/dotnet/dotnet</Uri>
5147
<Sha>0a01b394b186e190a80cb55740c13f6293cf5446</Sha>
5248
</Dependency>

eng/Versions.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
<MicrosoftExtensionsHostFactoryResolverSourcesVersion>10.0.0-preview.6.25278.103</MicrosoftExtensionsHostFactoryResolverSourcesVersion>
2727
<MicrosoftExtensionsLoggingVersion>10.0.0-preview.6.25278.103</MicrosoftExtensionsLoggingVersion>
2828
<MicrosoftNETCoreAppRefVersion>10.0.0-preview.6.25278.103</MicrosoftNETCoreAppRefVersion>
29-
<MicrosoftNETCoreAppRuntimewinx64Version>10.0.0-preview.6.25278.103</MicrosoftNETCoreAppRuntimewinx64Version>
29+
<MicrosoftNETCorePlatformsVersion>10.0.0-preview.6.25278.103</MicrosoftNETCorePlatformsVersion>
3030
<SystemTextEncodingsWebVersion>10.0.0-preview.6.25278.103</SystemTextEncodingsWebVersion>
3131
<SystemTextJsonVersion>10.0.0-preview.6.25278.103</SystemTextJsonVersion>
3232
<SystemFormatsAsn1Version>10.0.0-preview.6.25278.103</SystemFormatsAsn1Version>

eng/helix.proj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
<SasToken>$([System.Environment]::GetEnvironmentVariable('DotNetBuildsInternalReadSasToken'))</SasToken>
3131
</AdditionalDotNetPackageFeed>
3232

33-
<AdditionalDotNetPackage Include="$(MicrosoftNETCoreAppRuntimewinx64Version)">
33+
<AdditionalDotNetPackage Include="$(MicrosoftNETCoreAppRefVersion)">
3434
<PackageType>runtime</PackageType>
3535
</AdditionalDotNetPackage>
3636
</ItemGroup>

global.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"dotnet": "10.0.100-preview.6.25272.112",
1414
"runtimes": {
1515
"dotnet": [
16-
"$(MicrosoftNETCoreAppRuntimewinx64Version)"
16+
"$(MicrosoftNETCorePlatformsVersion)"
1717
]
1818
}
1919
},

test/Directory.Build.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
<ItemGroup>
1111
<FrameworkReference Update="Microsoft.NETCore.App"
1212
Condition="'$(TargetFramework)' == '$(DefaultNetCoreTargetFramework)'"
13-
RuntimeFrameworkVersion="$(MicrosoftNETCoreAppRuntimewinx64Version)"
13+
RuntimeFrameworkVersion="$(MicrosoftNETCoreAppRefVersion)"
1414
TargetingPackVersion="$(MicrosoftNETCoreAppRefVersion)" />
1515
</ItemGroup>
1616

0 commit comments

Comments
 (0)