Replies: 1 comment 1 reply
-
Isn't |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
From what I can tell is there no option to simply provide a
BufferedImage
for aWrappedServerPing.CompressedImage
instance to be created.This should be considered to be implemented, as every server and proxy platform seems to provide an option to create a sort of Favicon instance from a BufferedImage itself.
The fact that ProtocolLib seems to be the only case to not offer this makes it a lot more difficult to write a central system to allow stuff such as creation of favicons for multiple platforms.
I myself encountered this exact issue. While Paper, BungeeCord and Velocity have an option to create a Favicon, do I have to use a byte array for ProtocolLib, to achieve the same goal for Spigot.
So, if doable should it be considered to implement a method like
fromPng(BufferedImage)
forWrappedServerPing.CompressedImage
creation.Maybe also consider removing a few other methods? Like what situation justifies the usage of a(n encoded) String?
Beta Was this translation helpful? Give feedback.
All reactions