Skip to content

Conversation

neilmartin83
Copy link
Contributor

Change

Thank you for your contribution !
Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context.
List any dependencies that are required for this change.

Not a 11.19 specific PR. This ensures parity between API request/response bodies and SDK types. Added back the Flush* fields as these are set by the API to false as default when omitted anyway, so this makes no difference here. Decided it was better to include them for completeness.

MaidUsernameMergeEnabled appeared in 11.16 and is useful for ADUE flows - not exposed in the GUI and gets set to false whenever anyone makes a change to UIE settings in the GUI, so an ideal candidate for TF to manage where needed...

PersonalDeviceEnrolmentType needs to be ommited if empty, or we get an API 409 error. If omitted, the API sets a default value. Was causing an issue with the UIE resource block in TF if not including that field's argument (it's optional in the provider and the API).

Type of Change

Please DELETE options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)
  • Refactor (refactoring code, removing code, changing code structure)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@neilmartin83 neilmartin83 requested a review from ShocOne as a code owner July 31, 2025 16:06
@thejoeker12 thejoeker12 merged commit ecefd79 into deploymenttheory:main Aug 4, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants