fix: DH-20229: Value is null or undefined when scrolling rollup #2538
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Value is null or undefined" error was thrown from calling
IrisGridTreeTableModel.textAlignForCell
when scrolling a table with expanded rollups while hovering on a row.I think these errors are due to
textAlignForCell
not being able to find the row in the viewport when scrolling rapidly as it has already left the viewport, and so it shouldn't matter what is returned in this case if the cell isn't displayed on screen.To address potential issues with scrolling in the future, some tests involving scrolling a table were added. These mainly represent the failure scenario seen in the ticket, but more can be added in the future to test other scenarios.
IrisGridRenderer.getExpandButtonPosition
, and a fallback value has been added to replace the not null assertions there as well. This is the same pattern used inIrisGridTextCellRenderer.ts.getCellOverflowButtonPosition