-
Notifications
You must be signed in to change notification settings - Fork 33
fix: reduce spectrum popover excessive padding #2530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
packages/components/src/theme/theme-spectrum/theme-spectrum-overrides.css
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2530 +/- ##
========================================
Coverage 44.59% 44.59%
========================================
Files 764 764
Lines 42825 42825
Branches 10967 10769 -198
========================================
Hits 19096 19096
Misses 23718 23718
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ugh, I think copilot "helped" when I re-targeted the class from dialog to popover, it change the variable too for me... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified the padding in the styleguide. Looks good.
Reduces from ~40px to ~16px. Targets popover dialog only.
Added to styleguide just to be able to preview.