Skip to content

Conversation

dsmmcken
Copy link
Contributor

@dsmmcken dsmmcken commented Sep 5, 2025

Reduces from ~40px to ~16px. Targets popover dialog only.

Added to styleguide just to be able to preview.

@dsmmcken dsmmcken requested a review from bmingles September 5, 2025 14:20
Copy link
Contributor

@bmingles bmingles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests failed due to stylelint error.

Also, looking at the styleguide, I see the CSS variable got updated, but I'm not seeing it impact the padding of the dialog.

image

Looks like --spectrum-dialog-padding may be the variable that needs to be set

Copy link

codecov bot commented Sep 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.59%. Comparing base (9c969f0) to head (dc16689).

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #2530    +/-   ##
========================================
  Coverage   44.59%   44.59%            
========================================
  Files         764      764            
  Lines       42825    42825            
  Branches    10967    10769   -198     
========================================
  Hits        19096    19096            
  Misses      23718    23718            
  Partials       11       11            
Flag Coverage Δ
unit 44.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dsmmcken
Copy link
Contributor Author

dsmmcken commented Sep 5, 2025

Looks like --spectrum-dialog-padding may be the variable that needs to be set

ugh, I think copilot "helped" when I re-targeted the class from dialog to popover, it change the variable too for me...

@dsmmcken dsmmcken requested a review from bmingles September 5, 2025 18:48
Copy link
Contributor

@bmingles bmingles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified the padding in the styleguide. Looks good.

@dsmmcken dsmmcken merged commit 53c4d26 into main Sep 5, 2025
11 checks passed
@dsmmcken dsmmcken deleted the dmckenzie_reduce_popover branch September 5, 2025 20:19
@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants