Skip to content

Conversation

gzh2003
Copy link
Contributor

@gzh2003 gzh2003 commented Aug 6, 2025

For DH-10205. The current implementation breaks enterprise code that uses hydration/dehydration without providing a columnAlignmentMap (such as QueryMonitorGridPanel).

We could update the few places that call hydrate/dehydrate iris grid when updating packages in DHE. But it is probably better to set defaults as Matt suggested.

@gzh2003 gzh2003 requested a review from mofojed August 6, 2025 16:20
@gzh2003 gzh2003 self-assigned this Aug 6, 2025
Copy link

codecov bot commented Aug 6, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.61%. Comparing base (eca54ca) to head (ae1869d).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
packages/iris-grid/src/IrisGridUtils.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2518      +/-   ##
==========================================
+ Coverage   44.59%   44.61%   +0.01%     
==========================================
  Files         764      764              
  Lines       42778    42800      +22     
  Branches    10962    10766     -196     
==========================================
+ Hits        19078    19096      +18     
- Misses      23641    23693      +52     
+ Partials       59       11      -48     
Flag Coverage Δ
unit 44.61% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gzh2003 gzh2003 merged commit acee8f1 into deephaven:main Aug 6, 2025
12 checks passed
@gzh2003 gzh2003 deleted the DH-10205-add-default-hydrate-dehydrate-values branch August 6, 2025 17:41
@github-actions github-actions bot locked and limited conversation to collaborators Aug 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants