Skip to content

Conversation

mattrunyon
Copy link
Collaborator

Small thing needed for ui.resolve b/c the JS API may not be available on mount of UITable, so irisGridUtils may be null

This won't affect any rendering of table plugins since model is also required and possibly undefined until the JS API and table are loaded.

@mattrunyon mattrunyon requested a review from a team July 31, 2025 21:24
@mattrunyon mattrunyon self-assigned this Jul 31, 2025
@mattrunyon mattrunyon requested review from bmingles and dgodinez-dh and removed request for a team and bmingles July 31, 2025 21:24
@mattrunyon mattrunyon enabled auto-merge (squash) July 31, 2025 21:24
Copy link

codecov bot commented Jul 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.59%. Comparing base (a155da6) to head (0c61e79).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2515      +/-   ##
==========================================
- Coverage   44.61%   44.59%   -0.02%     
==========================================
  Files         763      764       +1     
  Lines       42715    42778      +63     
  Branches    10947    10962      +15     
==========================================
+ Hits        19057    19078      +21     
- Misses      23600    23641      +41     
- Partials       58       59       +1     
Flag Coverage Δ
unit 44.59% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mattrunyon mattrunyon merged commit 9378fa4 into deephaven:main Aug 1, 2025
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants