Skip to content

Conversation

mattrunyon
Copy link
Collaborator

@mattrunyon mattrunyon commented Jul 23, 2025

Part of DH-19001. Tested with my VM mattrunyon-gplus which has the updated dh.ui and DHE web UI as well. Used the notebook w/ the ticket number as several examples, and the Demo and DemoDashboard queries w/ different users with different permissions to view those queries. Tested using tables/figures/pickers and restarting the queries to ensure they restarted and could continue being used.

This is mostly type changes to augment the object fetcher stuff to accept a URI.

Also adds the associated api to the useWidget hook needed for PQ URIs in DHE.

Renamed useTableClose to useWidgetClose as a more generic util and deprecated useTableClose. They are the same, just more permissive types since this can apply to non-tables

@mattrunyon mattrunyon requested a review from mofojed July 23, 2025 21:32
@mattrunyon mattrunyon self-assigned this Jul 23, 2025
Copy link

codecov bot commented Jul 23, 2025

Codecov Report

❌ Patch coverage is 87.87879% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.61%. Comparing base (d65ed40) to head (9086fe4).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...s/app-utils/src/components/ConnectionBootstrap.tsx 0.00% 3 Missing ⚠️
...pi-components/src/spectrum/utils/usePickerProps.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2509      +/-   ##
==========================================
- Coverage   44.67%   44.61%   -0.06%     
==========================================
  Files         762      763       +1     
  Lines       42618    42715      +97     
  Branches    10710    10750      +40     
==========================================
+ Hits        19038    19057      +19     
- Misses      23569    23647      +78     
  Partials       11       11              
Flag Coverage Δ
unit 44.61% <87.87%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ticket # / how did you test this?

@mattrunyon mattrunyon requested a review from mofojed July 25, 2025 17:21
@mattrunyon
Copy link
Collaborator Author

Added info to the PR description. I'll update the Jira ticket with a detailed test plan

mofojed
mofojed previously approved these changes Jul 29, 2025
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one minor suggestion

@mattrunyon mattrunyon requested a review from mofojed July 29, 2025 17:14
@mofojed mofojed merged commit 545d2bc into deephaven:main Jul 29, 2025
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants