-
Notifications
You must be signed in to change notification settings - Fork 33
feat: Add URI support and api associated with widget to useWidget #2509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2509 +/- ##
==========================================
- Coverage 44.67% 44.61% -0.06%
==========================================
Files 762 763 +1
Lines 42618 42715 +97
Branches 10710 10750 +40
==========================================
+ Hits 19038 19057 +19
- Misses 23569 23647 +78
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ticket # / how did you test this?
Added info to the PR description. I'll update the Jira ticket with a detailed test plan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, one minor suggestion
Part of DH-19001. Tested with my VM
mattrunyon-gplus
which has the updated dh.ui and DHE web UI as well. Used the notebook w/ the ticket number as several examples, and theDemo
andDemoDashboard
queries w/ different users with different permissions to view those queries. Tested using tables/figures/pickers and restarting the queries to ensure they restarted and could continue being used.This is mostly type changes to augment the object fetcher stuff to accept a URI.
Also adds the associated
api
to theuseWidget
hook needed for PQ URIs in DHE.Renamed
useTableClose
touseWidgetClose
as a more generic util and deprecateduseTableClose
. They are the same, just more permissive types since this can apply to non-tables