fix: DH-19963: Remove grid-block-events when Grid unmounts #2507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgodinez-dh
requested review from
a team and
vbabich
and removed request for
a team
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2507 +/- ##
==========================================
- Coverage 44.67% 44.67% -0.01%
==========================================
Files 762 762
Lines 42617 42618 +1
Branches 10906 10906
==========================================
Hits 19038 19038
- Misses 23522 23523 +1
Partials 57 57
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mattrunyon
reviewed
Jul 22, 2025
packages/grid/src/Grid.tsx
Outdated
|
|
||
| this.stopDragTimer(); | ||
|
|
||
| document.documentElement.classList.remove('grid-block-events'); |
There was a problem hiding this comment.
Bender and I briefly talked about this in our 1:1 before he assigned back to you and mentioned only removing if the grid caused the block.
Looked like maybe we should just call removeDocumentCursor on unmount instead since it also potentially changes the cursor
mofojed
approved these changes
Jul 23, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for https://deephaven.atlassian.net/browse/DH-19963