Skip to content

Conversation

gzh2003
Copy link
Contributor

@gzh2003 gzh2003 commented Jul 21, 2025

For DH-19601. Input tables with aggregations in the footer were experiencing conflicts with insertions to the pending area. This pr pins aggregations to the top of input tables, that way we have the bottom of the table reserved for pending rows.

@gzh2003 gzh2003 requested a review from mofojed July 21, 2025 20:00
@gzh2003 gzh2003 self-assigned this Jul 21, 2025
Copy link

codecov bot commented Jul 21, 2025

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 44.59%. Comparing base (e32b68f) to head (003737b).
Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
packages/iris-grid/src/IrisGrid.tsx 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2502      +/-   ##
==========================================
- Coverage   44.62%   44.59%   -0.04%     
==========================================
  Files         759      763       +4     
  Lines       42548    42700     +152     
  Branches    10693    10741      +48     
==========================================
+ Hits        18988    19041      +53     
- Misses      23549    23648      +99     
  Partials       11       11              
Flag Coverage Δ
unit 44.59% <42.85%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gzh2003 gzh2003 changed the title fix: DH-19601: Fix aggregations to the top for input tables fix: DH-19601: Pin aggregations to the top for input tables Jul 22, 2025
@gzh2003 gzh2003 changed the title fix: DH-19601: Pin aggregations to the top for input tables fix: DH-19601: Pin aggregations to the top in input tables Jul 23, 2025
@gzh2003 gzh2003 requested a review from mofojed July 25, 2025 15:04
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@gzh2003 gzh2003 merged commit 8407e4c into deephaven:main Jul 28, 2025
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 28, 2025
@gzh2003 gzh2003 deleted the DH-19601-aggregations-applied-to-input-tables-get-rendered-incorrectly branch July 28, 2025 13:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants