-
Notifications
You must be signed in to change notification settings - Fork 33
fix: DH-19601: Pin aggregations to the top in input tables #2502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: DH-19601: Pin aggregations to the top in input tables #2502
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2502 +/- ##
==========================================
- Coverage 44.62% 44.59% -0.04%
==========================================
Files 759 763 +4
Lines 42548 42700 +152
Branches 10693 10741 +48
==========================================
+ Hits 18988 19041 +53
- Misses 23549 23648 +99
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
For DH-19601. Input tables with aggregations in the footer were experiencing conflicts with insertions to the pending area. This pr pins aggregations to the top of input tables, that way we have the bottom of the table reserved for pending rows.