-
Notifications
You must be signed in to change notification settings - Fork 33
feat: DH-19722: Better handling for large numbers of open dashboards #2481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: DH-19722: Better handling for large numbers of open dashboards #2481
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2481 +/- ##
==========================================
- Coverage 44.62% 44.59% -0.04%
==========================================
Files 759 763 +4
Lines 42548 42692 +144
Branches 10693 10734 +41
==========================================
+ Hits 18988 19038 +50
- Misses 23549 23643 +94
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f7ce2f5
to
c9e8783
Compare
); | ||
|
||
const handleMouseDown = useCallback((event: React.MouseEvent) => { | ||
// Prevent mousedown from taking focus away from the search input |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a fan of mousedown on the dashboard list stealing focus from the search input. The list items already have CSS styling for this, so I think retaining focus on the search input keeps things cleaner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, I generally try to avoid capturing just a mouse down or a mouse up, as that could potentially cause issues for any other libraries or cause issues with accessibility... seems okay for this case.
In another scenario, eating just an mouseup
event could screw up anything that had started listening for mousedown
and then expected a mouseup
... Capturing down is a little less dangerous though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple minor things, looks good
4608893
to
148590a
Compare
For DH-19722. This PR adds a popper for searching and filtering through dashboards. It supports keyboard navigation and includes a global shortcut (
Ctrl+Shift+D
/Cmd+Shift+D
) to toggle the quick filter popper.Changes:
SearchInput
to display the associated shortcut