CI - disable cirq-rigetti tests (quantumlib#7433)

- Remove cirq-rigetti tests from ci-daily.yml
- Remove cirq-rigetti tests from ci.yml
- Hardcode exclusion of cirq_rigetti in cirq-core unit tests
- Drop cirq-rigetti requirements from dev.env.txt
- Exclude cirq-rigetti from typecheck

Partially implements quantumlib#7297

Author: pavoljuhas

.github/workflows/ci-daily.yml

@@ -30,26 +30,15 @@ jobs:
           cache-dependency-path: |
             **/requirements.txt
             dev_tools/requirements/**/*.txt
-      - name: Install system requirements
-        run: |
-          sudo apt-get update
-          sudo apt-get install libffi7
       - name: Install requirements
         run: |
           pip install --upgrade cirq~=1.0.dev &&
-            version=$(pip show cirq | sed -n "s/^Version: //p" | grep .) &&
-            pip install "cirq-rigetti==${version}" &&
             pip install \
-              -r dev_tools/requirements/deps/format.txt \
               -r dev_tools/requirements/deps/pylint.txt \
               -r dev_tools/requirements/deps/pytest.txt \
               -r dev_tools/requirements/deps/notebook.txt
-      - name: Run Quil dependencies
-        run: docker compose -f cirq-rigetti/docker-compose.test.yaml up -d
       - name: Pytest check
-        run: check/pytest -n auto --ignore=cirq-core/cirq/contrib --rigetti-integration --enable-slow-tests
-      - name: Stop Quil dependencies
-        run: docker compose -f cirq-rigetti/docker-compose.test.yaml down
+        run: check/pytest -n auto --ignore=cirq-core/cirq/contrib --ignore=cirq-rigetti --enable-slow-tests
   windows:
     if: github.repository_owner == 'quantumlib'
     name: Pytest Windows
@@ -70,13 +59,11 @@ jobs:
       - name: Install requirements
         run: |
           pip install --upgrade cirq~=1.0.dev &&
-            pip install --upgrade cirq-rigetti~=1.0.dev &&
-            pip install -r dev_tools/requirements/deps/format.txt &&
             pip install -r dev_tools/requirements/deps/pylint.txt &&
             pip install -r dev_tools/requirements/deps/pytest.txt &&
             pip install -r dev_tools/requirements/deps/notebook.txt
       - name: Pytest Windows
-        run: check/pytest -n auto --ignore=cirq-core/cirq/contrib --enable-slow-tests
+        run: check/pytest -n auto --ignore=cirq-core/cirq/contrib --ignore=cirq-rigetti --enable-slow-tests
         shell: bash
   macos:
     if: github.repository_owner == 'quantumlib'
@@ -98,12 +85,9 @@ jobs:
       - name: Install requirements
         run: |
           pip install --upgrade cirq~=1.0.dev &&
-            version=$(pip show cirq | sed -n "s/^Version: //p" | grep .) &&
-            pip install "cirq-rigetti==${version}" &&
             pip install \
-              -r dev_tools/requirements/deps/format.txt \
               -r dev_tools/requirements/deps/pylint.txt \
               -r dev_tools/requirements/deps/pytest.txt \
               -r dev_tools/requirements/deps/notebook.txt
       - name: Pytest check
-        run: check/pytest -n auto --ignore=cirq-core/cirq/contrib --enable-slow-tests
+        run: check/pytest -n auto --ignore=cirq-core/cirq/contrib --ignore=cirq-rigetti --enable-slow-tests

.github/workflows/ci.yml

@@ -201,20 +201,12 @@ jobs:
           cache-dependency-path: |
             **/requirements.txt
             dev_tools/requirements/**/*.txt
-      - name: Install system packages
-        run: |
-          sudo apt-get update
-          sudo apt-get install libffi7
       - name: Install requirements
         run: |
           pip install --upgrade setuptools wheel
           pip install --upgrade --upgrade-strategy eager -r dev_tools/requirements/dev.env.txt
-      - name: Run Quil dependencies
-        run: docker compose -f cirq-rigetti/docker-compose.test.yaml up -d
       - name: Pytest check
-        run: check/pytest -n auto --durations=20 --ignore=cirq-core/cirq/contrib --rigetti-integration
-      - name: Stop Quil dependencies
-        run: docker compose -f cirq-rigetti/docker-compose.test.yaml down
+        run: check/pytest -n auto --durations=20 --ignore=cirq-core/cirq/contrib --ignore=cirq-rigetti
   # TODO(#6706) remove after we start using NumPy 2.0 in regular pytest
   pytest-numpy-2:
     if: github.repository_owner == 'quantumlib'
@@ -235,10 +227,6 @@ jobs:
           cache-dependency-path: |
             **/requirements.txt
             dev_tools/requirements/**/*.txt
-      - name: Install system packages
-        run: |
-          sudo apt-get update
-          sudo apt-get install libffi7
       - name: Install requirements
         run: |
           pip install wheel
@@ -299,24 +287,16 @@ jobs:
           cache-dependency-path: |
             **/requirements.txt
             dev_tools/requirements/**/*.txt
-      - name: Install system requirements
-        run: |
-          sudo apt-get update
-          sudo apt-get install libffi7
       - name: Install requirements
         run: |
           pip install --upgrade setuptools wheel
           pip install --upgrade --upgrade-strategy eager -r dev_tools/requirements/dev.env.txt
-      - name: Run Quil dependencies
-        run: docker compose -f cirq-rigetti/docker-compose.test.yaml up -d
       - name: Coverage check
-        run: check/pytest-and-incremental-coverage -n auto --rigetti-integration
+        run: check/pytest-and-incremental-coverage -n auto --ignore=cirq-rigetti
       - name: Upload coverage reports to Codecov
         uses: codecov/codecov-action@18283e04ce6e62d37312384ff67231eb8fd56d24 # v5
         env:
           CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
-      - name: Stop Quil dependencies
-        run: docker compose -f cirq-rigetti/docker-compose.test.yaml down
   windows:
     if: github.repository_owner == 'quantumlib'
     name: Pytest Windows
@@ -343,7 +323,7 @@ jobs:
       - name: Pytest Windows
         run: |
           source dev_tools/pypath
-          check/pytest -n auto --durations=20 --ignore=cirq-core/cirq/contrib
+          check/pytest -n auto --durations=20 --ignore=cirq-core/cirq/contrib --ignore=cirq-rigetti
         shell: bash
   macos:
     if: github.repository_owner == 'quantumlib'
@@ -369,7 +349,7 @@ jobs:
           pip install --upgrade setuptools wheel
           pip install --upgrade --upgrade-strategy eager -r dev_tools/requirements/no-contrib.env.txt
       - name: Pytest check
-        run: check/pytest -n auto --durations=20 --ignore=cirq-core/cirq/contrib
+        run: check/pytest -n auto --durations=20 --ignore=cirq-core/cirq/contrib --ignore=cirq-rigetti
   notebooks-stable:
     if: github.repository_owner == 'quantumlib'
     name: Changed Notebooks Isolated Test against Cirq stable

check/mypy

@@ -17,6 +17,13 @@ CONFIG_FILE='mypy.ini'
 read -r -a CIRQ_PACKAGES < \
     <(env PYTHONPATH=. python dev_tools/modules.py list --mode package-path)
 
+# TODO(#7297) clean up after cirq-rigetti removal
+for i in "${!CIRQ_PACKAGES[@]}"; do
+    if [[ "${CIRQ_PACKAGES[i]}" == cirq-rigetti* ]]; then
+        unset "CIRQ_PACKAGES[i]"
+    fi
+done
+
 echo -e -n "\033[31m"
 mypy --config-file=dev_tools/conf/$CONFIG_FILE "$@" "${CIRQ_PACKAGES[@]}" dev_tools examples
 result=$?

cirq-core/cirq/protocols/hash_from_pickle_test.py

@@ -87,8 +87,8 @@ def _read_json(json_filename: str) -> Any:
 
 def test_exclude_json_files_has_valid_entries() -> None:
     """Verify _EXCLUDE_JSON_FILES has valid entries."""
-    # do not check rigetti files if not installed
-    skip_rigetti = all(m.name != "cirq_rigetti" for m in MODULE_TEST_SPECS)
+    # cirq_rigetti is getting removed per #7058
+    skip_rigetti = True
     json_file_validates = lambda f: any(
         m.test_data_path.joinpath(os.path.basename(f)).is_file() for m in MODULE_TEST_SPECS
     ) or (skip_rigetti and f.startswith("cirq_rigetti/"))

cirq-core/cirq/protocols/json_serialization_test.py

@@ -52,18 +52,10 @@ class _ModuleDeprecation:
     'cirq_ionq': None,
     'cirq_google': None,
     'cirq_pasqal': None,
-    'cirq_rigetti': None,
     'cirq.protocols': None,
     'non_existent_should_be_fine': None,
 }
 
-# TODO(#6706) remove after cirq_rigetti supports NumPy 2.0
-if np.__version__.startswith("2."):  # pragma: no cover
-    warnings.warn(
-        "json_serialization_test - ignoring cirq_rigetti due to incompatibility with NumPy 2.0"
-    )
-    del TESTED_MODULES["cirq_rigetti"]
-
 
 def _get_testspecs_for_modules() -> list[ModuleJsonTestSpec]:
     modules = []

dev_tools/conf/mypy.ini

@@ -9,6 +9,11 @@ warn_redundant_casts = true
 [mypy-cirq.*]
 no_implicit_reexport = true
 
+# TODO(#7297) clean up after cirq-rigetti removal
+[mypy-cirq_rigetti]
+follow_imports = silent
+ignore_missing_imports = true
+
 [mypy-__main__]
 follow_imports = silent
 ignore_missing_imports = true

dev_tools/requirements/deps/cirq-all-no-contrib.txt

@@ -5,5 +5,4 @@
 -r ../../../cirq-google/requirements.txt
 -r ../../../cirq-ionq/requirements.txt
 -r ../../../cirq-pasqal/requirements.txt
--r ../../../cirq-rigetti/requirements.txt
 -r ../../../cirq-web/requirements.txt