Skip to content

Commit 34c78df

Browse files
mfranzkegithub-actions[bot]nmerget
authored
fix(card): removing obsolete, but harmful declaration regarding wrapping button and link styles (#4935)
* fix(card): removing (most likely) obsolete, but harmful declaration * feat: added changeset * auto update snapshots (#4980) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Revert "fix(card): removing (most likely) obsolete, but harmful declaration" This reverts commit b3bbd17. * refactor: only disabling the minimum set of necessary declarations * auto update snapshots (#4991) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * auto update snapshots (#5269) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix: issue with fonts * auto update snapshots (#5298) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update cool-bugs-chew.md --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Nicolas Merget <[email protected]> Co-authored-by: Nicolas Merget <[email protected]>
1 parent 13d6b36 commit 34c78df

File tree

2 files changed

+17
-2
lines changed

2 files changed

+17
-2
lines changed

.changeset/cool-bugs-chew.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
---
2+
"@db-ux/core-components": patch
3+
"@db-ux/ngx-core-components": patch
4+
"@db-ux/react-core-components": patch
5+
"@db-ux/v-core-components": patch
6+
"@db-ux/wc-core-components": patch
7+
---
8+
9+
fix(card): Remove the obsolete but harmful declaration regarding wrapping button and link styles.

packages/components/src/components/card/card.scss

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,15 @@
33
@use "@db-ux/core-foundations/build/styles/helpers";
44
@use "../../styles/internal/component";
55

6-
:is(a, button) {
6+
:is(a[href], button) {
7+
// Resetting button and link specific declarations
78
&:has(.db-card) {
8-
all: unset;
9+
text-decoration: unset;
10+
margin: unset;
11+
border: unset;
12+
background-color: transparent;
13+
padding: unset;
14+
font: inherit;
915
}
1016

1117
@include helpers.hover {

0 commit comments

Comments
 (0)