Skip to content

Commit 2b54cd9

Browse files
committed
Use = to document default values for named parameters - Fixes #2087
1 parent a1d86f2 commit 2b54cd9

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

lib/src/render/parameter_renderer.dart

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -208,11 +208,7 @@ abstract class ParameterRenderer {
208208
}
209209

210210
if (param.hasDefaultValue) {
211-
if (param.isNamed) {
212-
buf.write(': ');
213-
} else {
214-
buf.write(' = ');
215-
}
211+
buf.write(' = ');
216212
buf.write(defaultValue(param.defaultValue));
217213
}
218214
return buf.toString();

test/end2end/model_test.dart

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3601,6 +3601,13 @@ String topLevelFunction(int param1, bool param2, Cool coolBeans,
36013601
expect(intCheckOptional.isNamed, isTrue);
36023602
});
36033603

3604+
test('uses = instead of : to set default value', () {
3605+
final rendered =
3606+
ParameterRendererHtml().renderLinkedParams([intCheckOptional]);
3607+
print(rendered);
3608+
expect(rendered.contains('</span> = <span'), isTrue);
3609+
});
3610+
36043611
test('linkedName', () {
36053612
expect(intCheckOptional.modelType.linkedName, 'int');
36063613
});

0 commit comments

Comments
 (0)