#209: Added warning if Cobertura file is invalid

Author: danielpalme

src/AzureDevopsTask/ReportGenerator/task.json

@@ -13,7 +13,7 @@
     "version": {
         "Major": 1,
         "Minor": 0,
-        "Patch": 20
+        "Patch": 21
     },
     "instanceNameFormat": "ReportGenerator",
     "groups": [

src/AzureDevopsTask/vss-extension.json

@@ -2,7 +2,7 @@
     "manifestVersion": 1,
     "id": "reportgenerator",
     "name": "ReportGenerator",
-    "version": "1.0.20",
+    "version": "1.0.21",
     "publisher": "Palmmedia",
     "public": true,
     "targets": [

src/Readme.txt

@@ -58,10 +58,13 @@ For further details take a look at LICENSE.txt.
 
 CHANGELOG
 
+4.0.12.0
+
+    * Fix: Issue #209: Added warning if Cobertura file is invalid
+
 4.0.11.0
 
     * Fix: Fixed icons on collapse all / expand all
-
 4.0.10.0
 
     * New: Issue #203: Dark theme for Azure DevOps

src/ReportGenerator.Console.NetCore/ReportGenerator.Console.NetCore.csproj

@@ -7,8 +7,8 @@
     <AssemblyName>ReportGenerator</AssemblyName>
     <RootNamespace>Palmmedia.ReportGenerator</RootNamespace>
     <StartupObject>Palmmedia.ReportGenerator.Console.NetCore.Program</StartupObject>
-    <AssemblyVersion>4.0.11.0</AssemblyVersion>
-    <FileVersion>4.0.11.0</FileVersion>
+    <AssemblyVersion>4.0.12.0</AssemblyVersion>
+    <FileVersion>4.0.12.0</FileVersion>
   </PropertyGroup>
 
   <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">

src/ReportGenerator.Console/Properties/AssemblyInfo.cs

@@ -31,5 +31,5 @@
 // You can specify all the values or you can default the Build and Revision Numbers
 // by using the '*' as shown below:
 // [assembly: AssemblyVersion("1.0.*")]
-[assembly: AssemblyVersion("4.0.11.0")]
-[assembly: AssemblyFileVersion("4.0.11.0")]
+[assembly: AssemblyVersion("4.0.12.0")]
+[assembly: AssemblyFileVersion("4.0.12.0")]

src/ReportGenerator.Core.Test/ReportGenerator.Core.Test.csproj

@@ -4,8 +4,8 @@
     <TargetFramework>netcoreapp2.0</TargetFramework>
     <IsPackable>false</IsPackable>
     <RootNamespace>Palmmedia.ReportGenerator.Core.Test</RootNamespace>
-    <AssemblyVersion>4.0.11.0</AssemblyVersion>
-    <FileVersion>4.0.11.0</FileVersion>
+    <AssemblyVersion>4.0.12.0</AssemblyVersion>
+    <FileVersion>4.0.12.0</FileVersion>
   </PropertyGroup>
 
 

src/ReportGenerator.Core/Parser/CoberturaParser.cs

@@ -70,6 +70,14 @@ public override ParserResult Parse(XContainer report)
             var modules = report.Descendants("package")
               .ToArray();
 
+            if (modules.Length == 0)
+            {
+                if (report.Descendants("packages").Elements("class").Any())
+                {
+                    Logger.Error("  " + Resources.ErrorInvalidCoberturaReport);
+                }
+            }
+
             var assemblyNames = modules
                 .Select(m => m.Attribute("name").Value)
                 .Distinct()

src/ReportGenerator.Core/Properties/Resources.Designer.cs

@@ -168,6 +168,9 @@
   <data name="ErrorDuringSavingHistoricReport" xml:space="preserve">
     <value>Error during saving historic report '{0}': {1}</value>
   </data>
+  <data name="ErrorInvalidCoberturaReport" xml:space="preserve">
+    <value>The Cobertura report is not well formed. The &lt;packages&gt; element should contain &lt;package&gt; elements and not &lt;class&gt; elements.</value>
+  </data>
   <data name="ErrorPartCover" xml:space="preserve">
     <value>PartCover is no longer supported. If you want to generate coverage reports based on PartCover, please use version 3.x of ReportGenerator.</value>
   </data>

src/ReportGenerator.Core/Properties/Resources.resx

@@ -7,8 +7,8 @@
     <AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath>
     <CopyLocalLockFileAssemblies>true</CopyLocalLockFileAssemblies>
     <AssemblyName>ReportGenerator.Core</AssemblyName>
-    <AssemblyVersion>4.0.11.0</AssemblyVersion>
-    <FileVersion>4.0.11.0</FileVersion>
+    <AssemblyVersion>4.0.12.0</AssemblyVersion>
+    <FileVersion>4.0.12.0</FileVersion>
   </PropertyGroup>
 
   <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">