Fix vuex store warnings in unit tests

Author: MetRonnie

src/store/app.module.js

@@ -15,11 +15,11 @@
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
-const state = {
+const state = () => ({
   drawer: null,
   title: null,
-  jobTheme: null
-}
+  jobTheme: null,
+})
 
 const mutations = {
   setDrawer (state, drawer) {

src/store/options.js

@@ -21,7 +21,7 @@ import { workflows } from './workflows.module'
 import { user } from './user.module'
 
 // State
-const state = {
+const state = () => ({
   /**
    * Application alert.
    */
@@ -35,7 +35,7 @@ const state = {
    * TODO: we can probably remove it and use a different approach for alerts (see bootstrap toast).
    */
   refCount: 0
-}
+})
 
 // Actions
 const actions = {

src/store/user.module.js

@@ -15,9 +15,9 @@
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
-export const state = {
-  user: null
-}
+export const state = () => ({
+  user: null,
+})
 
 export const mutations = {
   SET_USER (state, user) {

src/store/workflows.module.js

@@ -35,7 +35,7 @@ export function merge (data, update) {
   }
 }
 
-const state = {
+const state = () => ({
   cylcTree: {
     $index: {},
     children: []
@@ -50,7 +50,7 @@ const state = {
    * @type {String}
    */
   workflowName: null
-}
+})
 
 const getters = {
   /* Return matching nodes from the store.

tests/unit/utils/graphql.spec.js

@@ -15,14 +15,13 @@
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
-import { createStore } from 'vuex'
 // need the polyfill as otherwise ApolloClient fails to be imported as it checks for a global fetch object on import...
 import 'cross-fetch/polyfill'
 import * as graphql from '@/graphql'
+import { store } from '@/store/index'
 import storeOptions from '@/store/options'
 
 describe('utils', () => {
-  const store = createStore(storeOptions)
   describe('graphql', () => {
     describe('ApolloClient', () => {
       it('should create an apollo client', () => {
@@ -34,8 +33,8 @@ describe('utils', () => {
 
     describe('SubscriptionClient', () => {
       beforeEach(() => {
-        store.commit('SET_OFFLINE', false)
-        store.state.offline = false
+        store.replaceState(storeOptions.state())
+        expect(store.state.offline).to.be.false
       })
       it('should create a subscription client', () => {
         const subscriptionClient = graphql.createSubscriptionClient(