Skip to content

Conversation

@browniebroke
Copy link
Contributor

No description provided.

Comment on lines -16 to -17
url(r"^admin/", include(admin.site.urls)),
url(r"^support/", include(support_admin.urls)),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The url() function is deprecated and will be dropped in Django 4. This would be displayed while running test with warning enabled (-Wall)

@crccheck crccheck changed the title fix: cleanup Django compatibility shims for <2.0 feat!: cleanup Django compatibility shims for <2.0 Nov 9, 2021
@crccheck crccheck changed the title feat!: cleanup Django compatibility shims for <2.0 feat!: Delete Django compatibility shims for <2.0 Nov 9, 2021
@crccheck
Copy link
Owner

crccheck commented Nov 9, 2021

I need to do another pass to see if there are any other releases to do before doing a breaking change.

@browniebroke
Copy link
Contributor Author

browniebroke commented Nov 9, 2021

Side question: I noticed the title updates and now I'm wondering... Are you following conventional commit strictly?

Asking as I'm using it on some of my project and it streamline the release process massively, I basically automated changelog + release generation + upload to PyPI with python-semantic-release. It works great with GitHub actions, because unlike other CIs, you don't have to run it on each build to master, you make a workflow that is manually triggered with workflow_dispatch.

If you start using it for release, it's easy to forget, but there are actions to either lint the PR title or commits, depending on your merge strategy.

(sorry for the long disgression 😄)

@crccheck
Copy link
Owner

crccheck commented Nov 10, 2021

yes, I want to! In fact, I was hoping to put release automation in before the next breaking change. I've been using https://semantic-release.gitbook.io/semantic-release/ in NodeJS land and the tooling in JS land is pretty great. I'm not up to speed on the Python equivalent.

Thanks for the links! I've got another project where I run stuff manually on workflow_dispatch too and I kinda like it better than releasing every commit so far

@crccheck
Copy link
Owner

crccheck commented Dec 7, 2021

Django 4.0 is out! I'll try to push one last maintenance release using semantic-release then merge this

@crccheck crccheck merged commit 88cfb3b into crccheck:master Mar 10, 2022
@browniebroke browniebroke deleted the cleanup/django-compat branch March 10, 2022 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants