[locale.categories] Index X_base classes and their members
#8434
+76
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Oh, I overlooked member types and static data members in derived classes. Is it better to handle them in the same PR? |
Contributor
|
Up to you! Adding any missing indexings is an improvement. More is better, and I'm sure these won't be the last ones! |
Enumerators of each unscoped enumeration type are indexed as members of the enclosing class of the enumeration.
frederick-vs-ja
force-pushed
the
index-locale-base-members
branch
from
bb69b5d to
e910948
Compare
Contributor
Author
|
The PR is closed due to some weird reason, I'll open a new one. |
Contributor
|
Is that because your fork got rerouted? You may need to file a ticket to have it re-attached to cplusplus/draft. |
Contributor
|
I believe GitHub support have restored all affected forks, so could you take another look? |
Contributor
Author
|
Opened #8496. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enumerators of each unscoped enumeration type are indexed as members of the enclosing class of the enumeration.
(Attempted to fix) #6080.