changes to coverage detail

Author: daveMueller

src/coverlet.core/CoverageDetails.cs

@@ -5,14 +5,24 @@ namespace Coverlet.Core
     internal class CoverageDetails
     {
         private double _averageModulePercent;
-        public double Covered { get; internal set; }
+        private double _covered;
+
+        public double Covered
+        {
+            get => _covered;
+            internal set
+            {
+                _covered = value;
+                Percent = Total == 0 ? 100D : Math.Floor((_covered / Total) * 10000) / 100;
+            }
+        }
+
         public int Total { get; internal set; }
+        public double Percent { get; internal set; }
         public double AverageModulePercent
         {
             get { return Math.Floor(_averageModulePercent * 100) / 100; }
             internal set { _averageModulePercent = value; }
         }
-
-        public double Percent => Total == 0 ? 0 : Math.Floor((Covered / Total) * 10000) / 100;
     }
 }

src/coverlet.core/CoverageSummary.cs

@@ -54,14 +54,18 @@ public CoverageDetails CalculateLineCoverage(Modules modules)
         {
             var details = new CoverageDetails();
             var accumPercent = 0.0D;
+
+            if (modules.Count == 0)
+                return details;
+
             foreach (var module in modules)
             {
                 var moduleCoverage = CalculateLineCoverage(module.Value);
                 details.Covered += moduleCoverage.Covered;
                 details.Total += moduleCoverage.Total;
                 accumPercent += moduleCoverage.Percent;
             }
-            details.AverageModulePercent = modules.Count == 0 ? 0 : accumPercent / modules.Count;
+            details.AverageModulePercent = accumPercent / modules.Count;
             return details;
         }
 
@@ -153,6 +157,10 @@ public CoverageDetails CalculateBranchCoverage(Modules modules)
         {
             var details = new CoverageDetails();
             var accumPercent = 0.0D;
+
+            if (modules.Count == 0)
+                return details;
+
             foreach (var module in modules)
             {
                 var moduleCoverage = CalculateBranchCoverage(module.Value);
@@ -213,6 +221,10 @@ public CoverageDetails CalculateMethodCoverage(Modules modules)
         {
             var details = new CoverageDetails();
             var accumPercent = 0.0D;
+
+            if (modules.Count == 0)
+                return details;
+
             foreach (var module in modules)
             {
                 var moduleCoverage = CalculateMethodCoverage(module.Value);

test/coverlet.integration.tests/DeterministicBuild.cs

@@ -70,7 +70,7 @@ public void Msbuild()
 
             DotnetCli($"test -c {_buildConfiguration} --no-build /p:CollectCoverage=true /p:Include=\"[coverletsample.integration.determisticbuild]*DeepThought\" /p:IncludeTestAssembly=true", out standardOutput, out _, _testProjectPath);
             Assert.Contains("Passed!", standardOutput);
-            Assert.Contains("| coverletsample.integration.determisticbuild | 100% | 0%     | 100%   |", standardOutput);
+            Assert.Contains("| coverletsample.integration.determisticbuild | 100% | 100%   | 100%   |", standardOutput);
             Assert.True(File.Exists(Path.Combine(_testProjectPath, "coverage.json")));
             AssertCoverage(standardOutput);
 
@@ -93,7 +93,7 @@ public void Msbuild_SourceLink()
 
             DotnetCli($"test -c {_buildConfiguration} --no-build /p:CollectCoverage=true /p:UseSourceLink=true /p:Include=\"[coverletsample.integration.determisticbuild]*DeepThought\" /p:IncludeTestAssembly=true", out standardOutput, out _, _testProjectPath);
             Assert.Contains("Passed!", standardOutput);
-            Assert.Contains("| coverletsample.integration.determisticbuild | 100% | 0%     | 100%   |", standardOutput);
+            Assert.Contains("| coverletsample.integration.determisticbuild | 100% | 100%   | 100%   |", standardOutput);
             Assert.True(File.Exists(Path.Combine(_testProjectPath, "coverage.json")));
             Assert.Contains("raw.githubusercontent.com", File.ReadAllText(Path.Combine(_testProjectPath, "coverage.json")));
             AssertCoverage(standardOutput);