fix CoverletOutput parameter

Author: Bertk

Documentation/MSBuildIntegration.md

@@ -50,6 +50,15 @@ To specify a directory where all results will be written to (especially if using
 dotnet test /p:CollectCoverage=true /p:CoverletOutput='./results/'
 ```
 
+_Note: escape characters might produce some unexpected results._
+
+|status| msbuild parameter |
+|---|---|
+|:heavy_check_mark:|`/p:CoverletOutput="C:/GitHub/coverlet/artifacts/Reports/coverlet.core/"`|
+|:heavy_check_mark:|`/p:CoverletOutput="C:\\GitHub\\coverlet\\artifacts\\Reports\\coverlet.core\\"`|
+|:heavy_check_mark:|`/p:CoverletOutput="C:\GitHub\coverlet\artifacts\Reports\coverlet.core\\"`|
+|:x:|`/p:CoverletOutput="C:\GitHub\coverlet\artifacts\Reports\coverlet.core\"`|
+
 The Coverlet MSBuild task sets the `CoverletReport` MSBuild item so that you can easily use the produced coverage reports. For example, using [ReportGenerator](https://github.com/danielpalme/ReportGenerator#usage--command-line-parameters) to generate an html coverage report.
 
 ```xml

eng/publish-coverage-results.yml

@@ -19,7 +19,7 @@ steps:
     script: |
       dotnet tool restore --add-source https://api.nuget.org/v3/index.json
       dotnet tool list
-      dotnet reportgenerator -reports:"${{parameters.reports}}" -targetdir:"$(Build.SourcesDirectory)\artifacts\CoverageReport" -reporttypes:"Html;HtmlInline_AzurePipelines_Dark;Cobertura" -assemblyfilters:"${{parameters.assemblyfilters}}" -classfilters:"${{parameters.classfilters}}" -verbosity:Verbose --minimumCoverageThresholds:lineCoverage=${{parameters.minimumLineCoverage}}
+      dotnet reportgenerator -reports:"${{parameters.reports}}" -targetdir:"$(Build.SourcesDirectory)\artifacts\CoverageReport" -reporttypes:"HtmlInline_AzurePipelines_Dark;Cobertura" -assemblyfilters:"${{parameters.assemblyfilters}}" -classfilters:"${{parameters.classfilters}}" -verbosity:Verbose --minimumCoverageThresholds:lineCoverage=${{parameters.minimumLineCoverage}}
 
 - publish: '$(Build.SourcesDirectory)/artifacts/CoverageReport'
   displayName: 'Publish CoverageReport Artifact'

src/coverlet.core/coverlet.core.csproj

@@ -14,11 +14,6 @@
     <PackageReference Include="Mono.Cecil" />
     <PackageReference Include="NuGet.Versioning" />
     <PackageReference Include="System.Text.Json" VersionOverride="8.0.1"/>
-    <!--<PackageReference Include="PolySharp" >
-      <PrivateAssets>all</PrivateAssets>
-      <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
-    </PackageReference>-->
-
   </ItemGroup>
 
   <ItemGroup  Condition="'$(TargetFramework)' != 'netstandard2.0'">

src/coverlet.msbuild.tasks/ReportWriter.cs

@@ -10,7 +10,7 @@ namespace Coverlet.MSbuild.Tasks
   internal class ReportWriter
   {
     private readonly string _coverletMultiTargetFrameworksCurrentTFM;
-    private readonly string _directory;
+    private string _directory;
     private readonly string _output;
     private readonly IReporter _reporter;
     private readonly IFileSystem _fileSystem;
@@ -30,9 +30,10 @@ public string WriteReport()
 
       if (filename == string.Empty)
       {
-        // empty filename for instance only directory is passed to CoverletOutput c:\reportpath
-        // c:\reportpath\coverage.reportedextension
+        // empty filename for instance only directory is passed to CoverletOutput 'c:/reportpath/'
+        // note: use always '/' and not backslash => 'c:\reportpath\coverage.cobertura.xml'
         filename = $"coverage.{_coverletMultiTargetFrameworksCurrentTFM}{separatorPoint}{_reporter.Extension}";
+        _directory = Path.GetFullPath(_output);
       }
       else if (Path.HasExtension(filename))
       {
@@ -49,6 +50,7 @@ public string WriteReport()
 
       string report = Path.Combine(_directory, filename);
       _fileSystem.WriteAllText(report, _reporter.Report(_result, _sourceRootTranslator));
+
       return report;
     }
   }

test/coverlet.tests.utils/Properties/AssemblyInfo.cs

@@ -8,4 +8,3 @@
 [assembly: InternalsVisibleTo("coverlet.core.tests, PublicKey=0024000004800000940000000602000000240000525341310004000001000100757cf9291d78a82e5bb58a827a3c46c2f959318327ad30d1b52e918321ffbd847fb21565b8576d2a3a24562a93e86c77a298b564a0f1b98f63d7a1441a3a8bcc206da3ed09d5dacc76e122a109a9d3ac608e21a054d667a2bae98510a1f0f653c0e6f58f42b4b3934f6012f5ec4a09b3dfd3e14d437ede1424bdb722aead64ad")]
 [assembly: InternalsVisibleTo("coverlet.integration.tests, PublicKey=002400000480000094000000060200000024000052534131000400000100010001d24efbe9cbc2dc49b7a3d2ae34ca37cfb69b4f450acd768a22ce5cd021c8a38ae7dc68b2809a1ac606ad531b578f192a5690b2986990cbda4dd84ec65a3a4c1c36f6d7bb18f08592b93091535eaee2f0c8e48763ed7f190db2008e1f9e0facd5c0df5aaab74febd3430e09a428a72e5e6b88357f92d78e47512d46ebdc3cbb")]
 
-