fix warnings

Author: Bertk

Directory.Build.props

@@ -13,7 +13,7 @@
     <AnalysisLevel>preview</AnalysisLevel>
     <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
     <LangVersion>preview</LangVersion>
-    <NoWarn>$(NoWarn);NU5105</NoWarn>
+    <NoWarn>$(NoWarn);NU5105;CS1591</NoWarn>
     <RestoreSources>
       https://api.nuget.org/v3/index.json;
     </RestoreSources>

src/coverlet.collector/DataCollection/CoverageWrapper.cs

@@ -17,6 +17,10 @@ internal class CoverageWrapper : ICoverageWrapper
         /// </summary>
         /// <param name="settings">Coverlet settings</param>
         /// <param name="coverletLogger">Coverlet logger</param>
+        /// <param name="instrumentationHelper"></param>
+        /// <param name="fileSystem"></param>
+        /// <param name="sourceRootTranslator"></param>
+        /// <param name="cecilSymbolHelper"></param>
         /// <returns>Coverage object</returns>
         public Coverage CreateCoverage(CoverletSettings settings, ILogger coverletLogger, IInstrumentationHelper instrumentationHelper, IFileSystem fileSystem, ISourceRootTranslator sourceRootTranslator, ICecilSymbolHelper cecilSymbolHelper)
         {

src/coverlet.collector/coverlet.collector.csproj

@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
     <TargetFramework>netstandard2.0</TargetFramework>
     <AssemblyTitle>coverlet.collector</AssemblyTitle>
@@ -15,6 +15,7 @@
     <TargetsForTfmSpecificContentInPackage>$(TargetsForTfmSpecificContentInPackage);PackBuildOutputs</TargetsForTfmSpecificContentInPackage>
     <!-- Open issue https://github.com/NuGet/Home/issues/8941 -->
     <NoWarn>$(NoWarn);NU5127</NoWarn>
+    <GenerateDocumentationFile>true</GenerateDocumentationFile>
   </PropertyGroup>
 
   <!-- Nuget package properties https://docs.microsoft.com/en-us/nuget/reference/msbuild-targets -->

src/coverlet.console/Program.cs

@@ -53,12 +53,12 @@ public static async Task<int> Main(string[] args)
             new Option<bool>("--use-source-link", "Specifies whether to use SourceLink URIs in place of file system paths.") { Arity = ArgumentArity.Zero },
             new Option<string[]>("--does-not-return-attribute", "Attributes that mark methods that do not return"){Arity = ArgumentArity.ZeroOrMore},
             new Option<string>("--exclude-assemblies-without-sources", "Specifies behaviour of heuristic to ignore assemblies with missing source documents."){ Arity = ArgumentArity.ZeroOrOne }
-            }.WithHandler(nameof(HandleCommandAsync));
+            }.WithHandler(nameof(HandleCommand));
 
             root.Description = "Cross platform .NET Core code coverage tool";
             return await root.InvokeAsync(args);
         }
-        private static async Task<int> HandleCommandAsync(string moduleOrAppDirectory,
+        private static Task<int> HandleCommand(string moduleOrAppDirectory,
                                                                string target,
                                                                string targetargs,
                                                                string output,
@@ -308,20 +308,20 @@ string excludeAssembliesWithoutSources
                     throw new Exception(exceptionMessageBuilder.ToString());
                 }
 
-                return exitCode;
+                return Task.FromResult(exitCode);
 
 
             }
 
             catch (Win32Exception we) when (we.Source == "System.Diagnostics.Process")
             {
                 logger.LogError($"Start process '{target}' failed with '{we.Message}'");
-                return exitCode > 0 ? exitCode : (int)CommandExitCodes.Exception;
+                return Task.FromResult(exitCode > 0 ? exitCode : (int)CommandExitCodes.Exception);
             }
             catch (Exception ex)
             {
                 logger.LogError(ex.Message);
-                return exitCode > 0 ? exitCode : (int)CommandExitCodes.Exception;
+                return Task.FromResult(exitCode > 0 ? exitCode : (int)CommandExitCodes.Exception);
             }
 
         }

src/coverlet.core/Reporters/CoberturaReporter.cs

@@ -3,7 +3,6 @@
 
 using System;
 using System.Collections.Generic;
-using System.Diagnostics;
 using System.Globalization;
 using System.IO;
 using System.Linq;

src/coverlet.core/coverlet.core.csproj

@@ -1,9 +1,10 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
     <OutputType>Library</OutputType>
     <TargetFramework>netstandard2.0</TargetFramework>
     <IsPackable>false</IsPackable>
+    <GenerateDocumentationFile>true</GenerateDocumentationFile>
   </PropertyGroup>
 
   <ItemGroup>

src/coverlet.msbuild.tasks/coverlet.msbuild.tasks.csproj

@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
     <OutputType>Library</OutputType>
@@ -15,6 +15,7 @@
           If you are packing with NuGet's MSBuild Pack target, you can set <SuppressDependenciesWhenPacking>true</SuppressDependenciesWhenPacking> in any PropertyGroup in your project file.
     -->
     <SuppressDependenciesWhenPacking>true</SuppressDependenciesWhenPacking>
+    <GenerateDocumentationFile>true</GenerateDocumentationFile>
   </PropertyGroup>
 
   <!-- Nuget package properties https://docs.microsoft.com/en-us/nuget/reference/msbuild-targets -->

test/coverlet.collector.tests/coverlet.collector.tests.csproj

@@ -1,9 +1,10 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
   <Import Project="$(RepoRoot)src\coverlet.msbuild.tasks\coverlet.msbuild.props" />
 
   <PropertyGroup>
     <TargetFramework>net6.0</TargetFramework>
     <IsPackable>false</IsPackable>
+    <GenerateDocumentationFile>true</GenerateDocumentationFile>
   </PropertyGroup>
 
   <ItemGroup>

test/coverlet.core.tests/Helpers/InstrumentationHelperTests.cs

@@ -6,7 +6,6 @@
 using Xunit;
 using System.Collections.Generic;
 using System.Linq;
-using Castle.Core.Internal;
 using Moq;
 using Coverlet.Core.Abstractions;
 using Coverlet.Core.Enums;

test/coverlet.core.tests/Instrumentation/ModuleTrackerTemplateTests.cs

@@ -123,26 +123,24 @@ public void MutexBlocksMultipleWriters()
             FunctionExecutor.Run(async () =>
             {
                 using var ctx = new TrackerContext();
-                using (var mutex = new Mutex(
-                true, Path.GetFileNameWithoutExtension(ModuleTrackerTemplate.HitsFilePath) + "_Mutex", out bool createdNew))
-                {
-                    Assert.True(createdNew);
+                using var mutex = new Mutex(
+                true, Path.GetFileNameWithoutExtension(ModuleTrackerTemplate.HitsFilePath) + "_Mutex", out bool createdNew);
+                Assert.True(createdNew);
 
-                    ModuleTrackerTemplate.HitsArray = new[] { 0, 1, 2, 3 };
-                    var unloadTask = Task.Run(() => ModuleTrackerTemplate.UnloadModule(null, null));
+                ModuleTrackerTemplate.HitsArray = new[] { 0, 1, 2, 3 };
+                var unloadTask = Task.Run(() => ModuleTrackerTemplate.UnloadModule(null, null));
 
-                    Assert.False(unloadTask.Wait(5));
+                Assert.False(unloadTask.Wait(5));
 
-                    WriteHitsFile(new[] { 0, 3, 2, 1 });
+                WriteHitsFile(new[] { 0, 3, 2, 1 });
 
-                    Assert.False(unloadTask.Wait(5));
+                Assert.False(unloadTask.Wait(5));
 
-                    mutex.ReleaseMutex();
-                    await unloadTask;
+                mutex.ReleaseMutex();
+                await unloadTask;
 
-                    int[] expectedHitsArray = new[] { 0, 4, 4, 4 };
-                    Assert.Equal(expectedHitsArray, ReadHitsFile());
-                }
+                int[] expectedHitsArray = new[] { 0, 4, 4, 4 };
+                Assert.Equal(expectedHitsArray, ReadHitsFile());
 
                 return 0;
             });