fix: removed none and enforced runtime exlusion

Signed-off-by: Brian <[email protected]>

Author: bmahabirbu

packages/frontend/src/lib/select/InferenceRuntimeSelect.spec.ts

@@ -21,9 +21,10 @@ import { beforeEach, vi, test, expect } from 'vitest';
 import { render, fireEvent, within } from '@testing-library/svelte';
 import InferenceRuntimeSelect from '/@/lib/select/InferenceRuntimeSelect.svelte';
 import { InferenceType } from '@shared/models/IInference';
+import * as os from 'node:os';
 
 const getFilteredOptions = (exclude: InferenceType[] = []): InferenceType[] =>
-  Object.values(InferenceType).filter(type => !exclude.includes(type));
+  Object.values(InferenceType).filter(type => type !== InferenceType.NONE && !exclude.includes(type));
 
 beforeEach(() => {
   // mock scrollIntoView
@@ -95,3 +96,22 @@ test('Exclude specific runtime from list', async () => {
     expect(itemTexts).toContain(included);
   });
 });
+
+test('Does not show OPENVINO on macOS', async () => {
+  const platformSpy = vi.spyOn(os, 'platform').mockReturnValue('darwin');
+
+  const { container } = render(InferenceRuntimeSelect, {
+    value: undefined,
+    disabled: false,
+  });
+
+  const input = within(container).getByLabelText('Select Inference Runtime');
+  await fireEvent.pointerUp(input);
+
+  const items = container.querySelectorAll('div[class~="list-item"]');
+  const itemTexts = Array.from(items).map(item => item.textContent?.trim());
+
+  expect(itemTexts).not.toContain(InferenceType.OPENVINO);
+
+  platformSpy.mockRestore();
+});

packages/frontend/src/lib/select/InferenceRuntimeSelect.svelte

@@ -10,7 +10,7 @@ interface Props {
 let { value = $bindable(), disabled, exclude = [] }: Props = $props();
 
 // Filter options based on optional exclude list
-const options = Object.values(InferenceType).filter(type => !exclude.includes(type));
+const options = Object.values(InferenceType).filter(type => type !== InferenceType.NONE && !exclude.includes(type));
 
 function handleOnChange(nValue: { value: string } | undefined): void {
   if (nValue) {

packages/frontend/src/pages/PlaygroundCreate.svelte

@@ -16,12 +16,10 @@ import ModelSelect from '/@/lib/select/ModelSelect.svelte';
 import { InferenceType } from '@shared/models/IInference';
 import InferenceRuntimeSelect from '/@/lib/select/InferenceRuntimeSelect.svelte';
 
-// Preset the runtime selection
 let runtime: InferenceType | undefined = undefined;
-// exlude whisper.cpp from selection
+// exlude certain runtimes from selection
 let exclude: InferenceType[] = [InferenceType.WHISPER_CPP];
 let localModels: ModelInfo[];
-// Special case for "ALL" returns runtimes with optional exclution
 $: localModels = $modelsInfo.filter(
   model => model.file && (!runtime || model.backend === runtime) && !exclude.includes(model.backend as InferenceType),
 );
@@ -38,7 +36,8 @@ let trackingId: string | undefined = undefined;
 // The trackedTasks are the tasks linked to the trackingId
 let trackedTasks: Task[] = [];
 
-$: if (localModels.length > 0) {
+// Preset model selection depending on runtime
+$: if (runtime && localModels.length > 0) {
   model = localModels[0];
 } else {
   model = undefined;